-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Insights transactions details shows only 1 blocking txn #88264
Labels
C-bug
Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
T-observability
Comments
j82w
added
C-bug
Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
T-sql-observability
labels
Sep 20, 2022
craig bot
pushed a commit
that referenced
this issue
Sep 22, 2022
88454: ui: insights transaction details support multiple blocking transactions r=j82w a=j82w This adds support for multiple blocking transactions for a single waiting transaction. The cards were merged into the table, and the data was piped through to show multiple rows. The total contention time was also fixed to aggregate the contention time instead of just picking the latest. before: https://loom.com/share/0384ed937a344e2fb0105fefbc313acb after: https://www.loom.com/share/78e906f50a694cd59ac893ddb9c2239a closes #88264 Release justification: Category 2: Bug fixes and low-risk updates to new functionality Release note: (ui change): Add support for multiple blocking transaction on insights transaction details page. Merged the cards into the table, and fixed the total contention time. 88470: *: upgrade grpc to v1.47.0 r=erikgrinaker a=pavelkalinnikov Fixes #81227 Release note: upgrade grpc from v1.46.0 to v.1.47.0 which fixes a subtle bug causing panic on a nil pointer. 88477: keys: mark 49 as reserved r=ajwerner a=ajwerner Release note: None 88496: persistedsqlstats: speed up a test r=yuzefovich a=yuzefovich Previously, a single unit test could take on the order of 4 minutes (or even exceed 5 minute timeout, rarely) because the job monitor checks whether a cluster setting has been updated only every minute, and we update the cluster setting twice in a unit test. This commit makes it so that in a testing setup the check happens every second. Release note: None 88499: bazel: upgrade `rules_go` r=rail a=healthy-pod Pull in cockroachdb/rules_go#8. Closes #88048 Release note: None Co-authored-by: j82w <jwilley@cockroachlabs.com> Co-authored-by: Pavel Kalinnikov <pavel@cockroachlabs.com> Co-authored-by: Andrew Werner <awerner32@gmail.com> Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com> Co-authored-by: healthy-pod <ahmad@cockroachlabs.com>
blathers-crl bot
pushed a commit
that referenced
this issue
Sep 22, 2022
closes #88264 Release justification: Category 2: Bug fixes and low-risk updates to new functionality Release note: (ui change): Add support for multiple blocking transaction on insights transaction details page. Merged the cards into the table, and fixed the total contention time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C-bug
Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
T-observability
It's possible that a single transaction can be blocked by multiple transactions. The insights transaction details page and sql activity active transaction details page only show one blocking transaction. It could be blocked on completely different table and statements. This might make it challenging as the current ui makes the assumption there would only ever be 1 blocked schema/database/table.
This shows that there are 2 txn ids blocking 8a5f..
The insights transaction details page only shows first blocking txn id instead of both in the table.
To reproduce:
Session1:
Session2:
Wait several seconds then continue:
Session1:
Session3:
Wait several seconds then continue:
Session2:
Jira issue: CRDB-19754
The text was updated successfully, but these errors were encountered: