synchronize when writing to the JSON converter #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have sporadically seen issues where tests appear to fail with `No pass/skip/fail event found for test`. This is apparently because the test output from `go test` is interspersed with normal `stderr` output from the test process (notice how the `PASS:` line is split by stderr output): ``` --- PASS: TeI220916 15:19:35.406930 702 3@pebble/event.go:649 [pebble,s?] 2 [JOB 1] MANIFEST created 000001 I220916 15:19:35.407183 702 3@pebble/event.go:677 [pebble,s?] 3 [JOB 1] WAL created 000002 ... I220916 15:19:35.414755 702 sql/colexec/colexectestutils/utils.go:691 [-] 22 batchSize=1/sel=false stWindowFramer/mode=Groups/start=OffsetFollowing/end=UnboundedFollowing#01/count=17 (0.00s) ``` Here we avoid this by adding extra synchronization to ensure we only write a whole line from one of the two streams at a time.
healthy-pod
approved these changes
Sep 22, 2022
healthy-pod
pushed a commit
to healthy-pod/cockroach
that referenced
this pull request
Sep 22, 2022
Pull in cockroachdb/rules_go#8. Closes cockroachdb#88048 Release note: None
craig bot
pushed a commit
to cockroachdb/cockroach
that referenced
this pull request
Sep 22, 2022
88454: ui: insights transaction details support multiple blocking transactions r=j82w a=j82w This adds support for multiple blocking transactions for a single waiting transaction. The cards were merged into the table, and the data was piped through to show multiple rows. The total contention time was also fixed to aggregate the contention time instead of just picking the latest. before: https://loom.com/share/0384ed937a344e2fb0105fefbc313acb after: https://www.loom.com/share/78e906f50a694cd59ac893ddb9c2239a closes #88264 Release justification: Category 2: Bug fixes and low-risk updates to new functionality Release note: (ui change): Add support for multiple blocking transaction on insights transaction details page. Merged the cards into the table, and fixed the total contention time. 88470: *: upgrade grpc to v1.47.0 r=erikgrinaker a=pavelkalinnikov Fixes #81227 Release note: upgrade grpc from v1.46.0 to v.1.47.0 which fixes a subtle bug causing panic on a nil pointer. 88477: keys: mark 49 as reserved r=ajwerner a=ajwerner Release note: None 88496: persistedsqlstats: speed up a test r=yuzefovich a=yuzefovich Previously, a single unit test could take on the order of 4 minutes (or even exceed 5 minute timeout, rarely) because the job monitor checks whether a cluster setting has been updated only every minute, and we update the cluster setting twice in a unit test. This commit makes it so that in a testing setup the check happens every second. Release note: None 88499: bazel: upgrade `rules_go` r=rail a=healthy-pod Pull in cockroachdb/rules_go#8. Closes #88048 Release note: None Co-authored-by: j82w <jwilley@cockroachlabs.com> Co-authored-by: Pavel Kalinnikov <pavel@cockroachlabs.com> Co-authored-by: Andrew Werner <awerner32@gmail.com> Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com> Co-authored-by: healthy-pod <ahmad@cockroachlabs.com>
This was referenced Nov 9, 2022
healthy-pod
pushed a commit
to healthy-pod/cockroach
that referenced
this pull request
Nov 9, 2022
Pull in cockroachdb/rules_go#8. Closes cockroachdb#88048 Release note: None
healthy-pod
pushed a commit
to healthy-pod/cockroach
that referenced
this pull request
Nov 14, 2022
Pull in cockroachdb/rules_go#8. Closes cockroachdb#88048 Release note: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have sporadically seen issues where tests appear to fail with
No pass/skip/fail event found for test. This is apparently becausethe test output from
go testis interspersed with normalstderroutput from the test process (notice how the
PASS:line is split bystderr output):
Here we avoid this by adding extra synchronization to ensure we only
write a whole line from one of the two streams at a time.