Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

synchronize when writing to the JSON converter #8

Merged
merged 1 commit into from
Sep 22, 2022

Commits on Sep 21, 2022

  1. synchronize when writing to the JSON converter

    We have sporadically seen issues where tests appear to fail with
    `No pass/skip/fail event found for test`. This is apparently because
    the test output from `go test` is interspersed with normal `stderr`
    output from the test process (notice how the `PASS:` line is split by
    stderr output):
    
    ```
    --- PASS: TeI220916 15:19:35.406930 702 3@pebble/event.go:649  [pebble,s?] 2  [JOB 1] MANIFEST created 000001
    I220916 15:19:35.407183 702 3@pebble/event.go:677  [pebble,s?] 3  [JOB 1] WAL created 000002
    ...
    I220916 15:19:35.414755 702 sql/colexec/colexectestutils/utils.go:691  [-] 22  batchSize=1/sel=false
    stWindowFramer/mode=Groups/start=OffsetFollowing/end=UnboundedFollowing#01/count=17 (0.00s)
    ```
    
    Here we avoid this by adding extra synchronization to ensure we only
    write a whole line from one of the two streams at a time.
    rickystewart committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    e5366a4 View commit details
    Browse the repository at this point in the history