sql: data race in schema changer / plan visitor #88628
Labels
branch-release-22.2
Used to mark GA and release blockers, technical advisories, and bugs for 22.2
C-bug
Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
GA-blocker
T-sql-foundations
SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Comments
jordanlewis
added
the
C-bug
|
Hi @ajwerner, please add branch-* labels to identify which branch(es) this release-blocker affects. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
ajwerner
added a commit
to ajwerner/cockroach
that referenced
this issue
Sep 26, 2022
The fundamental race here is that while the slots themselves were being copied by value, the "any" clauses which are a slice were not. The second bug here is that the "inline" values were not being properly reset. That bug could lead to problems when the query was run again in the context of a different element set. We need to reset those inline values too. Fixes cockroachdb#88628 Release note: None
ajwerner
added
the
branch-release-22.2
ajwerner
added a commit
to ajwerner/cockroach
that referenced
this issue
Sep 26, 2022
The fundamental race here is that while the slots themselves were being copied by value, the "any" clauses which are a slice were not. The second bug here is that the "inline" values were not being properly reset. That bug could lead to problems when the query was run again in the context of a different element set. We need to reset those inline values too. Fixes cockroachdb#88628 Release note: None
ajwerner
added a commit
to ajwerner/cockroach
that referenced
this issue
Sep 26, 2022
The fundamental race here is that while the slots themselves were being copied by value, the "any" clauses which are a slice were not. The second bug here is that the "inline" values were not being properly reset. That bug could lead to problems when the query was run again in the context of a different element set. We need to reset those inline values too. Fixes cockroachdb#88628 Release note: None
craig bot
pushed a commit
that referenced
this issue
Sep 26, 2022
88252: storage: add gc benchmarks with multiple range tombstones r=erikgrinaker a=aliher1911 Previously we only had tests that verify GC performance with no range tombstones or with a single range tombstone under all the data. This commit extends the benchmark to have many tombstones interleaving data at different keys. Release note: None Fixes #87417 88295: sql: add assertion for txn passed to internal executor r=ajwerner a=ZhouXing19 If an internal executor is created with a txn binding to it, it should not be used to execute a statement with a nil txn. Release note: None 88670: schemachanger/rel: fix race due to failure to clone constraint slots r=ajwerner a=ajwerner The fundamental race here is that while the slots themselves were being copied by value, the "any" clauses which are a slice were not. The second bug here is that the "inline" values were not being properly reset. That bug could lead to problems when the query was run again in the context of a different element set. We need to reset those inline values too. Fixes #88628 Release note: None 88716: roachprod: set default cluster settings when starting r=yuzefovich,srosenberg,smg260 a=renatolabs In #88514, the cluster start logic was refactored to reuse the same code across `init` and `start`, fixing a bug in the former. However, the refactoring overlooked the fact that we previously always set the default cluster settings when there's more than one node in the cluster. This fixes that by setting the default cluster settings in that case; one particularly important cluster setting is the license key, necessary for some roachtests. Fixes #88660 Fixes #88665 Fixes #88666 Fixes #88710. Release note: None Co-authored-by: Oleg Afanasyev <oleg@cockroachlabs.com> Co-authored-by: Jane Xing <zhouxing@uchicago.edu> Co-authored-by: Andrew Werner <awerner32@gmail.com> Co-authored-by: Renato Costa <renato@cockroachlabs.com>
ajwerner
added a commit
to ajwerner/cockroach
that referenced
this issue
Sep 27, 2022
The fundamental race here is that while the slots themselves were being copied by value, the "any" clauses which are a slice were not. The second bug here is that the "inline" values were not being properly reset. That bug could lead to problems when the query was run again in the context of a different element set. We need to reset those inline values too. Fixes cockroachdb#88628 Release note: None
exalate-issue-sync
bot
added
T-sql-foundations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Seen in unrelated PR (#86968)
Jira issue: CRDB-19987
The text was updated successfully, but these errors were encountered: