Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: django failed #88675

Closed
cockroach-teamcity opened this issue Sep 25, 2022 · 20 comments
Closed

roachtest: django failed #88675

cockroach-teamcity opened this issue Sep 25, 2022 · 20 comments
Assignees
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot.
Milestone

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Sep 25, 2022

roachtest.django failed with artifacts on master @ 51c8aae748d338549400c047796c6c9b892527da:

test artifacts and logs in: /artifacts/django/run_1
	orm_helpers.go:191,orm_helpers.go:117,django.go:217,django.go:228,test_runner.go:928: 
		Tests run on Cockroach v22.2.0-alpha.3-583-g51c8aae748
		Tests run against django cockroach-4.1.x
		9942 Total Tests Run
		9941 tests passed
		1 test failed
		645 tests skipped
		2 tests ignored
		0 tests passed unexpectedly
		1 test failed unexpectedly
		0 tests expected failed but skipped
		0 tests expected failed but not run
		---
		--- FAIL: aggregation.tests.AggregateTestCase.test_aggregation_exists_multivalued_outeref (unexpected)
		--- SKIP: backends.mysql.test_creation.DatabaseCreationTests.test_create_test_db_unexpected_error due to MySQL tests (expected)
		For a full summary look at the django artifacts 
		
		An updated blocklist (djangoBlocklist) is available in the artifacts' django log

Parameters: ROACHTEST_cloud=gce , ROACHTEST_cpu=16 , ROACHTEST_encrypted=false , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

/cc @cockroachdb/sql-experience

This test on roachdash | Improve this report!

Jira issue: CRDB-19854

@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. labels Sep 25, 2022
@cockroach-teamcity cockroach-teamcity added this to the 22.2 milestone Sep 25, 2022
@rafiss rafiss removed the release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. label Sep 25, 2022
@cockroach-teamcity
Copy link
Member Author

roachtest.django failed with artifacts on master @ ff13325e9368c4e8dd9a4d5cf4aa2ad2f33e9ac0:

test artifacts and logs in: /artifacts/django/run_1
	orm_helpers.go:191,orm_helpers.go:117,django.go:217,django.go:228,test_runner.go:928: 
		Tests run on Cockroach v22.2.0-alpha.3-593-gff13325e93
		Tests run against django cockroach-4.1.x
		9942 Total Tests Run
		9941 tests passed
		1 test failed
		645 tests skipped
		2 tests ignored
		0 tests passed unexpectedly
		1 test failed unexpectedly
		0 tests expected failed but skipped
		0 tests expected failed but not run
		---
		--- FAIL: aggregation.tests.AggregateTestCase.test_aggregation_exists_multivalued_outeref (unexpected)
		--- SKIP: backends.mysql.test_creation.DatabaseCreationTests.test_create_test_db_unexpected_error due to MySQL tests (expected)
		For a full summary look at the django artifacts 
		
		An updated blocklist (djangoBlocklist) is available in the artifacts' django log

Parameters: ROACHTEST_cloud=gce , ROACHTEST_cpu=16 , ROACHTEST_encrypted=false , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

roachtest.django failed with artifacts on master @ ff13325e9368c4e8dd9a4d5cf4aa2ad2f33e9ac0:

test artifacts and logs in: /artifacts/django/run_1
	orm_helpers.go:191,orm_helpers.go:117,django.go:217,django.go:228,test_runner.go:928: 
		Tests run on Cockroach v22.2.0-alpha.3-593-gff13325e93
		Tests run against django cockroach-4.1.x
		9942 Total Tests Run
		9941 tests passed
		1 test failed
		645 tests skipped
		2 tests ignored
		0 tests passed unexpectedly
		1 test failed unexpectedly
		0 tests expected failed but skipped
		0 tests expected failed but not run
		---
		--- FAIL: aggregation.tests.AggregateTestCase.test_aggregation_exists_multivalued_outeref (unexpected)
		--- SKIP: backends.mysql.test_creation.DatabaseCreationTests.test_create_test_db_unexpected_error due to MySQL tests (expected)
		For a full summary look at the django artifacts 
		
		An updated blocklist (djangoBlocklist) is available in the artifacts' django log

Parameters: ROACHTEST_cloud=gce , ROACHTEST_cpu=16 , ROACHTEST_encrypted=false , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@ZhouXing19
Copy link
Collaborator

ZhouXing19 commented Sep 26, 2022

======================================================================
ERROR: test_aggregation_exists_multivalued_outeref (aggregation.tests.AggregateTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/local/lib/python3.8/dist-packages/django/db/backends/utils.py", line 89, in _execute
    return self.cursor.execute(sql, params)
psycopg2.errors.SyntaxError: subquery must return only one column, found 9


The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/mnt/data1/django/tests/aggregation/tests.py", line 1667, in test_aggregation_exists_multivalued_outeref
    self.assertCountEqual(
  File "/usr/lib/python3.8/unittest/case.py", line 1254, in assertCountEqual
    first_seq, second_seq = list(first), list(second)
  File "/usr/local/lib/python3.8/dist-packages/django/db/models/query.py", line 376, in __len__
    self._fetch_all()
  File "/usr/local/lib/python3.8/dist-packages/django/db/models/query.py", line 1866, in _fetch_all
    self._result_cache = list(self._iterable_class(self))
  File "/usr/local/lib/python3.8/dist-packages/django/db/models/query.py", line 87, in __iter__
    results = compiler.execute_sql(
  File "/usr/local/lib/python3.8/dist-packages/django/db/models/sql/compiler.py", line 1395, in execute_sql
    cursor.execute(sql, params)
  File "/usr/local/lib/python3.8/dist-packages/django/db/backends/utils.py", line 67, in execute
    return self._execute_with_wrappers(
  File "/usr/local/lib/python3.8/dist-packages/django/db/backends/utils.py", line 80, in _execute_with_wrappers
    return executor(sql, params, many, context)
  File "/usr/local/lib/python3.8/dist-packages/django/db/backends/utils.py", line 89, in _execute
    return self.cursor.execute(sql, params)
  File "/usr/local/lib/python3.8/dist-packages/django/db/utils.py", line 91, in __exit__
    raise dj_exc_value.with_traceback(traceback) from exc_value
  File "/usr/local/lib/python3.8/dist-packages/django/db/backends/utils.py", line 89, in _execute
    return self.cursor.execute(sql, params)
django.db.utils.ProgrammingError: subquery must return only one column, found 9

The failed test_aggregation_exists_multivalued_outeref test was added recently, but 2 weeks earlier than the failure shows up on our end.

    def test_aggregation_exists_multivalued_outeref(self):
        self.assertCountEqual(
            Publisher.objects.annotate(
                books_exists=Exists(
                    Book.objects.filter(publisher=OuterRef("book__publisher"))
                ),
                books_count=Count("book"),
            ),
            Publisher.objects.all(),
        )

@rafiss rafiss self-assigned this Sep 26, 2022
@cockroach-teamcity
Copy link
Member Author

roachtest.django failed with artifacts on master @ a0bfa6dafcc206301d3a21887c374db63b377075:

test artifacts and logs in: /artifacts/django/run_1
	orm_helpers.go:191,orm_helpers.go:117,django.go:217,django.go:228,test_runner.go:928: 
		Tests run on Cockroach v22.2.0-alpha.3-643-ga0bfa6dafc
		Tests run against django cockroach-4.1.x
		9942 Total Tests Run
		9941 tests passed
		1 test failed
		645 tests skipped
		2 tests ignored
		0 tests passed unexpectedly
		1 test failed unexpectedly
		0 tests expected failed but skipped
		0 tests expected failed but not run
		---
		--- SKIP: backends.mysql.test_creation.DatabaseCreationTests.test_create_test_db_unexpected_error due to MySQL tests (expected)
		--- FAIL: aggregation.tests.AggregateTestCase.test_aggregation_exists_multivalued_outeref (unexpected)
		For a full summary look at the django artifacts 
		
		An updated blocklist (djangoBlocklist) is available in the artifacts' django log

Parameters: ROACHTEST_cloud=gce , ROACHTEST_cpu=16 , ROACHTEST_encrypted=false , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

roachtest.django failed with artifacts on master @ 4982322e91c37c6d0249dc5597b9e02eec19848d:

test artifacts and logs in: /artifacts/django/run_1
	orm_helpers.go:191,orm_helpers.go:117,django.go:217,django.go:228,test_runner.go:928: 
		Tests run on Cockroach v22.2.0-alpha.3-690-g4982322e91
		Tests run against django cockroach-4.1.x
		9942 Total Tests Run
		9941 tests passed
		1 test failed
		645 tests skipped
		2 tests ignored
		0 tests passed unexpectedly
		1 test failed unexpectedly
		0 tests expected failed but skipped
		0 tests expected failed but not run
		---
		--- FAIL: aggregation.tests.AggregateTestCase.test_aggregation_exists_multivalued_outeref (unexpected)
		--- SKIP: backends.mysql.test_creation.DatabaseCreationTests.test_create_test_db_unexpected_error due to MySQL tests (expected)
		For a full summary look at the django artifacts 
		
		An updated blocklist (djangoBlocklist) is available in the artifacts' django log

Parameters: ROACHTEST_cloud=gce , ROACHTEST_cpu=16 , ROACHTEST_encrypted=false , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

roachtest.django failed with artifacts on master @ 4780ee15194e7d22b661ac92254b13cd2b71dcb1:

test artifacts and logs in: /artifacts/django/run_1
	orm_helpers.go:191,orm_helpers.go:117,django.go:217,django.go:228,test_runner.go:928: 
		Tests run on Cockroach v22.2.0-alpha.3-734-g4780ee1519
		Tests run against django cockroach-4.1.x
		9942 Total Tests Run
		9941 tests passed
		1 test failed
		645 tests skipped
		2 tests ignored
		0 tests passed unexpectedly
		1 test failed unexpectedly
		0 tests expected failed but skipped
		0 tests expected failed but not run
		---
		--- SKIP: backends.mysql.test_creation.DatabaseCreationTests.test_create_test_db_unexpected_error due to MySQL tests (expected)
		--- FAIL: aggregation.tests.AggregateTestCase.test_aggregation_exists_multivalued_outeref (unexpected)
		For a full summary look at the django artifacts 
		
		An updated blocklist (djangoBlocklist) is available in the artifacts' django log

Parameters: ROACHTEST_cloud=gce , ROACHTEST_cpu=16 , ROACHTEST_encrypted=false , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

roachtest.django failed with artifacts on master @ 4780ee15194e7d22b661ac92254b13cd2b71dcb1:

test artifacts and logs in: /artifacts/django/run_1
	orm_helpers.go:191,orm_helpers.go:117,django.go:217,django.go:228,test_runner.go:928: 
		Tests run on Cockroach v22.2.0-alpha.3-734-g4780ee1519
		Tests run against django cockroach-4.1.x
		9942 Total Tests Run
		9941 tests passed
		1 test failed
		645 tests skipped
		2 tests ignored
		0 tests passed unexpectedly
		1 test failed unexpectedly
		0 tests expected failed but skipped
		0 tests expected failed but not run
		---
		--- SKIP: backends.mysql.test_creation.DatabaseCreationTests.test_create_test_db_unexpected_error due to MySQL tests (expected)
		--- FAIL: aggregation.tests.AggregateTestCase.test_aggregation_exists_multivalued_outeref (unexpected)
		For a full summary look at the django artifacts 
		
		An updated blocklist (djangoBlocklist) is available in the artifacts' django log

Parameters: ROACHTEST_cloud=gce , ROACHTEST_cpu=16 , ROACHTEST_encrypted=false , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

roachtest.django failed with artifacts on master @ 801bfc62afd7128be180e3396d21a1e0b2daa227:

test artifacts and logs in: /artifacts/django/run_1
	orm_helpers.go:191,orm_helpers.go:117,django.go:217,django.go:228,test_runner.go:928: 
		Tests run on Cockroach v22.2.0-alpha.3-755-g801bfc62af
		Tests run against django cockroach-4.1.x
		9942 Total Tests Run
		9941 tests passed
		1 test failed
		645 tests skipped
		2 tests ignored
		0 tests passed unexpectedly
		1 test failed unexpectedly
		0 tests expected failed but skipped
		0 tests expected failed but not run
		---
		--- FAIL: aggregation.tests.AggregateTestCase.test_aggregation_exists_multivalued_outeref (unexpected)
		--- SKIP: backends.mysql.test_creation.DatabaseCreationTests.test_create_test_db_unexpected_error due to MySQL tests (expected)
		For a full summary look at the django artifacts 
		
		An updated blocklist (djangoBlocklist) is available in the artifacts' django log

Parameters: ROACHTEST_cloud=gce , ROACHTEST_cpu=16 , ROACHTEST_encrypted=false , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

roachtest.django failed with artifacts on master @ e786cba2b137a671d3846cf7a33e7b9dea2854e6:

test artifacts and logs in: /artifacts/django/run_1
	orm_helpers.go:191,orm_helpers.go:117,django.go:217,django.go:228,test_runner.go:928: 
		Tests run on Cockroach v22.2.0-alpha.3-814-ge786cba2b1
		Tests run against django cockroach-4.1.x
		9942 Total Tests Run
		9941 tests passed
		1 test failed
		645 tests skipped
		2 tests ignored
		0 tests passed unexpectedly
		1 test failed unexpectedly
		0 tests expected failed but skipped
		0 tests expected failed but not run
		---
		--- SKIP: backends.mysql.test_creation.DatabaseCreationTests.test_create_test_db_unexpected_error due to MySQL tests (expected)
		--- FAIL: aggregation.tests.AggregateTestCase.test_aggregation_exists_multivalued_outeref (unexpected)
		For a full summary look at the django artifacts 
		
		An updated blocklist (djangoBlocklist) is available in the artifacts' django log

Parameters: ROACHTEST_cloud=gce , ROACHTEST_cpu=16 , ROACHTEST_encrypted=false , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

roachtest.django failed with artifacts on master @ ff6961ef1741766b5cbe0b64ebf754e82343eb00:

test artifacts and logs in: /artifacts/django/run_1
	orm_helpers.go:191,orm_helpers.go:117,django.go:217,django.go:228,test_runner.go:928: 
		Tests run on Cockroach v22.2.0-alpha.3-829-gff6961ef17
		Tests run against django cockroach-4.1.x
		9934 Total Tests Run
		9930 tests passed
		4 tests failed
		646 tests skipped
		2 tests ignored
		0 tests passed unexpectedly
		4 tests failed unexpectedly
		0 tests expected failed but skipped
		0 tests expected failed but not run
		---
		--- FAIL: aggregation.tests.AggregateTestCase.test_aggregation_exists_multivalued_outeref (unexpected)
		--- FAIL: unittest.loader._FailedTest.model_regress.test_state (unexpected)
		--- SKIP: backends.mysql.test_creation.DatabaseCreationTests.test_create_test_db_unexpected_error due to MySQL tests (expected)
		--- FAIL: m2m_regress.tests.M2MRegressionTests.test_create_copy_with_m2m (unexpected)
		--- FAIL: many_to_many.tests.ManyToManyTests.test_related_manager_refresh (unexpected)
		For a full summary look at the django artifacts 
		
		An updated blocklist (djangoBlocklist) is available in the artifacts' django log

Parameters: ROACHTEST_cloud=gce , ROACHTEST_cpu=16 , ROACHTEST_encrypted=false , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

roachtest.django failed with artifacts on master @ 84384b50c023dd4c05fff76af85a6975f5d2b0ab:

test artifacts and logs in: /artifacts/django/run_1
	orm_helpers.go:191,orm_helpers.go:117,django.go:217,django.go:228,test_runner.go:928: 
		Tests run on Cockroach v22.2.0-alpha.3-835-g84384b50c0
		Tests run against django cockroach-4.1.x
		9934 Total Tests Run
		9930 tests passed
		4 tests failed
		646 tests skipped
		2 tests ignored
		0 tests passed unexpectedly
		4 tests failed unexpectedly
		0 tests expected failed but skipped
		0 tests expected failed but not run
		---
		--- FAIL: aggregation.tests.AggregateTestCase.test_aggregation_exists_multivalued_outeref (unexpected)
		--- FAIL: m2m_regress.tests.M2MRegressionTests.test_create_copy_with_m2m (unexpected)
		--- FAIL: unittest.loader._FailedTest.model_regress.test_state (unexpected)
		--- SKIP: backends.mysql.test_creation.DatabaseCreationTests.test_create_test_db_unexpected_error due to MySQL tests (expected)
		--- FAIL: many_to_many.tests.ManyToManyTests.test_related_manager_refresh (unexpected)
		For a full summary look at the django artifacts 
		
		An updated blocklist (djangoBlocklist) is available in the artifacts' django log

Parameters: ROACHTEST_cloud=gce , ROACHTEST_cpu=16 , ROACHTEST_encrypted=false , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

roachtest.django failed with artifacts on master @ 0eaeeb773474716753781289788fdd087fb9b166:

test artifacts and logs in: /artifacts/django/run_1
	orm_helpers.go:191,orm_helpers.go:117,django.go:217,django.go:228,test_runner.go:928: 
		Tests run on Cockroach v22.2.0-alpha.3-887-g0eaeeb7734
		Tests run against django cockroach-4.1.x
		9934 Total Tests Run
		9929 tests passed
		5 tests failed
		646 tests skipped
		2 tests ignored
		0 tests passed unexpectedly
		5 tests failed unexpectedly
		0 tests expected failed but skipped
		0 tests expected failed but not run
		---
		--- FAIL: m2m_regress.tests.M2MRegressionTests.test_create_copy_with_m2m (unexpected)
		--- FAIL: aggregation.tests.AggregateTestCase.test_aggregation_exists_multivalued_outeref (unexpected)
		--- FAIL: select_for_update.tests.SelectForUpdateTests.test_raw_lock_not_available (unexpected)
		--- FAIL: many_to_many.tests.ManyToManyTests.test_related_manager_refresh (unexpected)
		--- FAIL: unittest.loader._FailedTest.model_regress.test_state (unexpected)
		--- SKIP: backends.mysql.test_creation.DatabaseCreationTests.test_create_test_db_unexpected_error due to MySQL tests (expected)
		For a full summary look at the django artifacts 
		
		An updated blocklist (djangoBlocklist) is available in the artifacts' django log

Parameters: ROACHTEST_cloud=gce , ROACHTEST_cpu=16 , ROACHTEST_encrypted=false , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

roachtest.django failed with artifacts on master @ 0eaeeb773474716753781289788fdd087fb9b166:

test artifacts and logs in: /artifacts/django/run_1
	orm_helpers.go:191,orm_helpers.go:117,django.go:217,django.go:228,test_runner.go:928: 
		Tests run on Cockroach v22.2.0-alpha.3-887-g0eaeeb7734
		Tests run against django cockroach-4.1.x
		9922 Total Tests Run
		9921 tests passed
		1 test failed
		646 tests skipped
		2 tests ignored
		0 tests passed unexpectedly
		1 test failed unexpectedly
		0 tests expected failed but skipped
		0 tests expected failed but not run
		---
		--- FAIL: unittest.loader._FailedTest.check_framework.test_templates (unexpected)
		--- SKIP: backends.mysql.test_creation.DatabaseCreationTests.test_create_test_db_unexpected_error due to MySQL tests (expected)
		For a full summary look at the django artifacts 
		
		An updated blocklist (djangoBlocklist) is available in the artifacts' django log

Parameters: ROACHTEST_cloud=gce , ROACHTEST_cpu=16 , ROACHTEST_encrypted=false , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@timgraham
Copy link
Contributor

The failures here suggest that the Django tests directory is out of sync with the django directory. New tests are added but an old copy of Django persists, so the new regression tests fail. (This also happened a few weeks ago at #87368 (comment).) I'm not sure why this is happening in roachtest.

@timgraham
Copy link
Contributor

I think these tests are running with the latest copy of Django from PyPI rather than the copy cloned from the GitHub branch. I haven't put together how this could happen, but there was a new release of Django earlier today and this theory is consistent with the change in the failures above (test_templates now failing and the others fixed). Perhaps examining the build log would reveal details.

I noticed that asyncpg.go seems to install Django system-wide (using sudo)... but django.go uses a virtual environment and is supposed to install the version of Django that was cloned. Perhaps these commands aren't working as expected. For example, I wonder if the virtual environment activation carries over to subsequent commands.

@rafiss
Copy link
Collaborator

rafiss commented Oct 6, 2022

Nice finds. I wouldn't have expected the asyncpg test to affect this one -- they are run on different GCE instances, as far as I know.

It also looks like the last few runs passed. Was there another upstream change?

@timgraham
Copy link
Contributor

The Django fork is now in sync (as of two days ago) with the latest pip release of Django so yes, this is fixed for now, even as the underlying cause remains.

It looks like the virtualenv is indeed not actually used for package installation as I see "Defaulting to user installation because normal site-packages is not writeable" from the pip3 commands and things like "Requirement already satisfied: backports.zoneinfo in /usr/local/lib/python3.8/dist-packages (from Django==4.1.3.dev20221004134332) (0.2.1)". If it's not the asyncpg test, I haven't found where Django is being installed from PyPI though.

@rafiss
Copy link
Collaborator

rafiss commented Oct 6, 2022

Nice find. I guess we should change it to use sudo

@timgraham
Copy link
Contributor

I'd be inclined to remove sudo from all pip3 install commands unless we say why it's needed. (It's discouraged because of the chance of overwriting what the operating system provides and breaking other things.) I'd think that installing packages at the user level should work fine.

sudo pip3 usages:

pkg/cmd/roachtest/tests/sqlalchemy.go:		sudo pip3 install --upgrade --force-reinstall setuptools pytest==6.0.1 pytest-xdist psycopg2 alembic
pkg/cmd/roachtest/tests/sqlalchemy.go:		cd /mnt/data1/sqlalchemy-cockroachdb && sudo pip3 install .
pkg/cmd/roachtest/tests/asyncpg.go:			"cd /mnt/data1/asyncpg && sudo pip3 install django && pip3 install -e ."); err != nil {

The five usages in django.go don't use sudo. Presumably we can remove the virtual environment creation in django.go also unless we can fix the script to actually use it.

@rafiss
Copy link
Collaborator

rafiss commented Oct 12, 2022

I'm closing this issue since the test is passing currently, but I'll make a PR to remove sudo from those tests

@rafiss rafiss closed this as completed Oct 12, 2022
craig bot pushed a commit that referenced this issue Oct 18, 2022
89851: roachtest: avoid using sudo to install python packages r=e-mbrown a=rafiss

see also #88675

sudo can make it confusing which veresion of a package is being installed and used. This fixes the usage of virtualenvs, and avoid sudo.

This also removes per-version blocklists for python tools' tests.

Release note: None

90095: sql: bump workmem size to avoid sqllite flakes on index/1000 tests r=cucaroach a=cucaroach

Below ~70k these tests would flake like so:

```
pq: streamer budget: memory budget exceeded: 38112 bytes requested, 57344 currently allocated, 76801 bytes in budget
```

Fixes: #89635

Release note: None


Co-authored-by: Rafi Shamim <rafi@cockroachlabs.com>
Co-authored-by: Tommy Reilly <treilly@cockroachlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot.
Projects
None yet
Development

No branches or pull requests

4 participants