-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
roachtest: django failed #88675
Comments
roachtest.django failed with artifacts on master @ ff13325e9368c4e8dd9a4d5cf4aa2ad2f33e9ac0:
Parameters: Same failure on other branches
|
roachtest.django failed with artifacts on master @ ff13325e9368c4e8dd9a4d5cf4aa2ad2f33e9ac0:
Parameters: Same failure on other branches
|
The failed def test_aggregation_exists_multivalued_outeref(self):
self.assertCountEqual(
Publisher.objects.annotate(
books_exists=Exists(
Book.objects.filter(publisher=OuterRef("book__publisher"))
),
books_count=Count("book"),
),
Publisher.objects.all(),
) |
roachtest.django failed with artifacts on master @ a0bfa6dafcc206301d3a21887c374db63b377075:
Parameters: Same failure on other branches
|
roachtest.django failed with artifacts on master @ 4982322e91c37c6d0249dc5597b9e02eec19848d:
Parameters: Same failure on other branches
|
roachtest.django failed with artifacts on master @ 4780ee15194e7d22b661ac92254b13cd2b71dcb1:
Parameters: Same failure on other branches
|
roachtest.django failed with artifacts on master @ 4780ee15194e7d22b661ac92254b13cd2b71dcb1:
Parameters: Same failure on other branches
|
roachtest.django failed with artifacts on master @ 801bfc62afd7128be180e3396d21a1e0b2daa227:
Parameters: Same failure on other branches
|
roachtest.django failed with artifacts on master @ e786cba2b137a671d3846cf7a33e7b9dea2854e6:
Parameters: Same failure on other branches
|
roachtest.django failed with artifacts on master @ ff6961ef1741766b5cbe0b64ebf754e82343eb00:
Parameters: Same failure on other branches
|
roachtest.django failed with artifacts on master @ 84384b50c023dd4c05fff76af85a6975f5d2b0ab:
Parameters: Same failure on other branches
|
roachtest.django failed with artifacts on master @ 0eaeeb773474716753781289788fdd087fb9b166:
Parameters: Same failure on other branches
|
roachtest.django failed with artifacts on master @ 0eaeeb773474716753781289788fdd087fb9b166:
Parameters: Same failure on other branches
|
The failures here suggest that the Django |
I think these tests are running with the latest copy of Django from PyPI rather than the copy cloned from the GitHub branch. I haven't put together how this could happen, but there was a new release of Django earlier today and this theory is consistent with the change in the failures above ( I noticed that |
Nice finds. I wouldn't have expected the asyncpg test to affect this one -- they are run on different GCE instances, as far as I know. It also looks like the last few runs passed. Was there another upstream change? |
The Django fork is now in sync (as of two days ago) with the latest pip release of Django so yes, this is fixed for now, even as the underlying cause remains. It looks like the virtualenv is indeed not actually used for package installation as I see "Defaulting to user installation because normal site-packages is not writeable" from the pip3 commands and things like "Requirement already satisfied: backports.zoneinfo in /usr/local/lib/python3.8/dist-packages (from Django==4.1.3.dev20221004134332) (0.2.1)". If it's not the asyncpg test, I haven't found where Django is being installed from PyPI though. |
Nice find. I guess we should change it to use sudo |
I'd be inclined to remove sudo from all pip3 install commands unless we say why it's needed. (It's discouraged because of the chance of overwriting what the operating system provides and breaking other things.) I'd think that installing packages at the user level should work fine. sudo pip3 usages:
The five usages in django.go don't use sudo. Presumably we can remove the virtual environment creation in django.go also unless we can fix the script to actually use it. |
I'm closing this issue since the test is passing currently, but I'll make a PR to remove sudo from those tests |
89851: roachtest: avoid using sudo to install python packages r=e-mbrown a=rafiss see also #88675 sudo can make it confusing which veresion of a package is being installed and used. This fixes the usage of virtualenvs, and avoid sudo. This also removes per-version blocklists for python tools' tests. Release note: None 90095: sql: bump workmem size to avoid sqllite flakes on index/1000 tests r=cucaroach a=cucaroach Below ~70k these tests would flake like so: ``` pq: streamer budget: memory budget exceeded: 38112 bytes requested, 57344 currently allocated, 76801 bytes in budget ``` Fixes: #89635 Release note: None Co-authored-by: Rafi Shamim <rafi@cockroachlabs.com> Co-authored-by: Tommy Reilly <treilly@cockroachlabs.com>
roachtest.django failed with artifacts on master @ 51c8aae748d338549400c047796c6c9b892527da:
Parameters:
ROACHTEST_cloud=gce
,ROACHTEST_cpu=16
,ROACHTEST_encrypted=false
,ROACHTEST_ssd=0
Help
See: roachtest README
See: How To Investigate (internal)
This test on roachdash | Improve this report!
Jira issue: CRDB-19854
The text was updated successfully, but these errors were encountered: