Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: avoid using sudo to install python packages #89851

Merged
merged 1 commit into from
Oct 18, 2022

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented Oct 12, 2022

see also #88675

sudo can make it confusing which veresion of a package is being installed and used. This fixes the usage of virtualenvs, and avoid sudo.

This also removes per-version blocklists for python tools' tests.

Release note: None

@rafiss rafiss requested review from e-mbrown and a team October 12, 2022 19:36
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@e-mbrown e-mbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

sudo can make it confusing which version of a package is being
installed and used. This fixes the usage of virtualenv, and avoid sudo.

This also removes per-version blocklists for python tools' tests.

Release note: None
@rafiss
Copy link
Collaborator Author

rafiss commented Oct 18, 2022

tftr!

bors r=e-mbrown

@craig
Copy link
Contributor

craig bot commented Oct 18, 2022

Build succeeded:

@craig craig bot merged commit b2b8d10 into cockroachdb:master Oct 18, 2022
@blathers-crl
Copy link

blathers-crl bot commented Oct 18, 2022

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 7849cc1 to blathers/backport-release-22.1-89851: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.1.x failed. See errors above.


error creating merge commit from 7849cc1 to blathers/backport-release-22.2-89851: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.2.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants