kv: TestMergeQueueDoesNotInterruptReplicationChange flaked #94951
Assignees
Labels
branch-release-23.1
Used to mark GA and release blockers, technical advisories, and bugs for 23.1
C-test-failure
Broken test (automatically or manually discovered).
GA-blocker
skipped-test
T-kv
KV Team
Comments
msbutler
added
C-test-failure
msbutler
added a commit
to msbutler/cockroach
that referenced
this issue
Jan 9, 2023
TestStoreCapacityAfterSplit, TestMergeQueueDoesNotInterruptReplicationChange, testserver_test_22.1_22.2, testserve_upgrade_node. Informs: cockroachdb#94871, cockroachdb#94951, cockroachdb#92677 cockroachdb#94956 Release note: None
craig bot
pushed a commit
that referenced
this issue
Jan 9, 2023
94954: kv/server: skip a bunch of flakey tests r=adityamaru a=msbutler TestStoreCapacityAfterSplit, TestMergeQueueDoesNotInterruptReplicationChange, testserver_test_22.1_22.2, testserver_upgrade_node. Informs: #94871, #94951, #92677, #94956 Release note: None Co-authored-by: Michael Butler <butler@cockroachlabs.com>
|
Hi @nvanbenschoten, please add branch-* labels to identify which branch(es) this release-blocker affects. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
nvanbenschoten
added
the
branch-release-23.1
craig bot
pushed a commit
that referenced
this issue
Mar 20, 2023
98805: kvserver: unskip merge queue during snapshot test r=nvanbenschoten a=AlexTalks This change unskips `TestMergeQueueDoesNotInterruptReplicationChange`, which was skipped as potentially flaky in #94951. Despite repeated stress testing, this test no longer seems flaky, and correctly gets an error if attempting to enqueue a range in the merge queue during a replication change. Fixes: #94951 Release note: None 98809: sql/logictest: clarify retry comment r=mgartner a=mgartner Epic: None Release note: None 98844: testutils: move tenant or server logic into test server r=stevendanna a=herkolategan The logic to decide between returning a default test tenant, if one was started, or the server has been added to `testcluster` previously, but `testserver` can also benefit from exposing this logic for tests that do not require a whole cluster. Hence, this logic has been refactored to be available in both test cluster and test server. Epic: CRDB-18499 98888: kvserver: remove duplicate logging in s-rebalancer r=andrewbaptist a=kvoli Previously, the store rebalancer would log `load-based replica transfers successfully brought...` even when the store was not below the max threshold. The store rebalancer also logs when there are no available replica rebalancing actions remaining but the store still above the desired load threshold: `ran out of replicas worth transferring and load`. This log line was duplicated in both the post range rebalancing phase and in exiting the range rebalancing phase. This commit stops duplication by removing the exit log line and ensures that the `load-based replica transfers successfully brought...` log line occurs only when actually successful. Resolves: #98867 Release note: None 98959: Revert "Revert "backupccl: disallow restore of backups older than the minimum supported binary version"" r=dt a=adityamaru This reverts commit c510676. Some roachtests rely on fixtures generated before 22.2. To restore such fixtures that are outside our compatibility window we must run the restore with `unsafe_restore_incompatible_version`. Fixes: #98918 Fixes: #98930 Release note: None Epic: none 98997: multitenant: Increase timeout for kvtenantccl r=knz a=ajstorm The new TestTenantUpgradeInterlock test takes a long time to run (up to a minute locally) and has started timing out in nightly runs. On the suspicion that it's timing out strictly because it's long running, increase the timeout to see if that resolves the failures. Release note: None 99021: ui: fix jobs column name r=maryliag a=maryliag The Last Execution Time called was previously labelled as Last Modified Time by mistake. This commit fixes to use the correct name. Epic: None Release note (ui change): Update the Jobs table column name to the correct Last Execution Time. Co-authored-by: Alex Sarkesian <sarkesian@cockroachlabs.com> Co-authored-by: Marcus Gartner <marcus@cockroachlabs.com> Co-authored-by: Herko Lategan <herko@cockroachlabs.com> Co-authored-by: Austen McClernon <austen@cockroachlabs.com> Co-authored-by: adityamaru <adityamaru@gmail.com> Co-authored-by: Adam Storm <storm@cockroachlabs.com> Co-authored-by: maryliag <marylia@cockroachlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See flake here.
Jira issue: CRDB-23239
The text was updated successfully, but these errors were encountered: