Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

closedts: log err when incoming stream drops #101550

Merged
merged 1 commit into from
Apr 14, 2023

Conversation

aliher1911
Copy link
Contributor

Currently we don't log error in the warning if incoming closedts stream is dropped by remote. Since those events are not frequent it would be beneficial to log actual error as we don't expect anything other than EOF which is handled separately.
This PR adds error to the log message.

Epic: none

Release note: None

Currently we don't log error in the warning if incoming closedts
stream is dropped by remote. Since those events are not frequent
it would be beneficial to log actual error as we don't expect anything
other than EOF which is handled separately.
This PR adds error to the log message.

Epic: none

Release note: None
@aliher1911 aliher1911 requested review from renatolabs and a team April 14, 2023 15:18
@blathers-crl
Copy link

blathers-crl bot commented Apr 14, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@aliher1911
Copy link
Contributor Author

TFTR

bors r+

@craig
Copy link
Contributor

craig bot commented Apr 14, 2023

Build succeeded:

@craig craig bot merged commit 05c5f29 into cockroachdb:master Apr 14, 2023
@sean-
Copy link
Collaborator

sean- commented Aug 21, 2023

@aliher1911 or @erikgrinaker , any objection if I blathers backport 23.1 22.2 this PR?

@blathers-crl
Copy link

blathers-crl bot commented Aug 21, 2023

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error getting backport branch release-22.2`: unexpected status code: 404 Not Found

Backport to branch 22.2` failed. See errors above.


error getting backport branch release-this: unexpected status code: 404 Not Found

Backport to branch this failed. See errors above.


error getting backport branch release-PR?: unexpected status code: 404 Not Found

Backport to branch PR? failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants