-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-23.1: closedts: log err when incoming stream drops #109169
release-23.1: closedts: log err when incoming stream drops #109169
Conversation
Currently we don't log error in the warning if incoming closedts stream is dropped by remote. Since those events are not frequent it would be beneficial to log actual error as we don't expect anything other than EOF which is handled separately. This PR adds error to the log message. Epic: none Release note: None
26abc06
to
e61c57f
Compare
8b00050
to
b3b3ee0
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @erikgrinaker and @renatolabs)
Backport 1/1 commits from #101550 on behalf of @aliher1911.
/cc @cockroachdb/release
Currently we don't log error in the warning if incoming closedts stream is dropped by remote. Since those events are not frequent it would be beneficial to log actual error as we don't expect anything other than EOF which is handled separately.
This PR adds error to the log message.
Epic: none
Release note: None
Release justification: