Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1.0: ui: fix linegraph render for large clusters #101969

Closed

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Apr 20, 2023

Backport 1/1 commits from #101952 on behalf of @zachlite.

/cc @cockroachdb/release


We were feeding Math.min and Math.max very large arrays (length equal to ~10e7). These functions take variadic arguments, and the runtime can't handle that many arguments. As a result we blow the stack, causing uncaught range errors.

Instead, we'll use lodash min and max which are not variadic. Resolves #101377 Epic: None
Release note: None

Reproduction and Fix demonstrated on the command line:

Screenshot 2023-04-20 at 4 56 41 PM


Release justification:

We were feeding `Math.min` and `Math.max` very large arrays
(length equal to ~10e7). These functions take variadic arguments,
and the runtime can't handle that many arguments. As a result we
blow the stack, causing uncaught range errors.

Instead, we'll use lodash min and max which are not variadic.
Resolves #101377
Epic: None
Release note: None
@blathers-crl blathers-crl bot requested a review from a team April 20, 2023 22:46
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1.0-101952 branch from a432b07 to 9485400 Compare April 20, 2023 22:46
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Apr 20, 2023
@blathers-crl
Copy link
Author

blathers-crl bot commented Apr 20, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@maryliag
Copy link
Contributor

maryliag commented May 9, 2023

we're not backporting to 23.1.0 anymore, so this can be closed (the one for 23.1 is still valid)

@zachlite zachlite closed this May 9, 2023
@rafiss rafiss deleted the blathers/backport-release-23.1.0-101952 branch December 11, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants