-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-23.1: kvserver,storepool: misc rebalance logging improvements #102951
Conversation
6ff3598
to
73a83a3
Compare
e590d6b
to
cff194d
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @knz and @kvoli)
TYFTR - I'll bake this for a bit before trying to merge. |
The store list string returned the mean leases, ranges and queries-per-second float values without limiting the number of decimal places. This led to log lines with needlessly long decimals: `avg-ranges=40.66666666666667... avg-leases=10.166666666666666...` This commit updates the store list string formatting to 2 decimal places for float values. Release note: None
Previously, the easiest method of determining the current rebalance objective from logs was to view the cluster setting and check for logging indicating a mixed version cluster - this was cumbersome. This commit annotates the ctx in the store rebalancer loop with an additional tag: `obj`. The `obj` tag indicates the current rebalance objective, either `cpu` or `qps` currently. resolves: #102812 Release note: None
cff194d
to
518fd7e
Compare
Backport 2/2 commits from #102825 on behalf of @kvoli.
/cc @cockroachdb/release
The store list string returned the mean leases, ranges and
queries-per-second float values without limiting the number of decimal
places. This led to log lines with needlessly long decimals:
avg-ranges=40.66666666666667... avg-leases=10.166666666666666...
This PR updates the store list string formatting to 2 decimal
places for float values.
Previously, the easiest method of determining the current rebalance
objective from logs was to view the cluster setting and check for
logging indicating a mixed version cluster - this was cumbersome.
This PR annotates the ctx in the store rebalancer loop with an
additional tag:
obj
. Theobj
tag indicates the current rebalanceobjective, either
cpu
orqps
currently.resolves: #102812
Release note: None
Release justification: Log line only changes which improve obs.