Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-23.1: kvserver,storepool: misc rebalance logging improvements #102951

Merged
merged 2 commits into from
May 30, 2023
Merged

release-23.1: kvserver,storepool: misc rebalance logging improvements #102951

merged 2 commits into from
May 30, 2023

Commits on May 30, 2023

  1. storepool: limit storelist string to 2 decimals 

    The store list string returned the mean leases, ranges and
queries-per-second float values without limiting the number of decimal
places. This led to log lines with needlessly long decimals:

`avg-ranges=40.66666666666667... avg-leases=10.166666666666666...`

This commit updates the store list string formatting to 2 decimal
places for float values.

Release note: None
    @kvoli
    kvoli committed May 30, 2023
    Configuration menu
    Copy the full SHA
    79d9008 View commit details
    Browse the repository at this point in the history

  2. kvserver: annotate rebalance ctx with objective 

    Previously, the easiest method of determining the current rebalance
objective from logs was to view the cluster setting and check for
logging indicating a mixed version cluster - this was cumbersome.

This commit annotates the ctx in the store rebalancer loop with an
additional tag: `obj`. The `obj` tag indicates the current rebalance
objective, either `cpu` or `qps` currently.

resolves: #102812

Release note: None
    @kvoli
    kvoli committed May 30, 2023
    Configuration menu
    Copy the full SHA
    518fd7e View commit details
    Browse the repository at this point in the history