sql: emphasize "virtual cluster" in SQL syntax, keep "tenant" as alias

[knz]

Informs #106068.
Epic: CRDB-29380

See individual commits for details.

[cockroach-teamcity]

This change is 

[yuzefovich]

Just a few questions from me:

• what's the rationale for removing some of the syntax from the docs diagrams?
• what's the end vision for the code base (i.e. non-user-visible) as it relates to the word "tenant"?

Reviewed 11 of 11 files at r1, 6 of 6 files at r2, 6 of 6 files at r3, 4 of 4 files at r4, 6 of 6 files at r5, 2 of 2 files at r6, 9 of 9 files at r7, 7 of 7 files at r8, 15 of 15 files at r9, 3 of 3 files at r10, 16 of 16 files at r11, 11 of 11 files at r12, 4 of 4 files at r13, 9 of 9 files at r14, 10 of 10 files at r15, 1 of 1 files at r16, 8 of 8 files at r17, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @knz and @stevendanna)

---

-- commits line 4 at r1:
nit: should we rename include_all_secondary_tenants field in jobs.proto too?

---

pkg/multitenant/mtinfopb/info.proto line 46 at r9 (raw file):

  // DroppedName is the name the tenant had before DROP VIRTUAL
  // CLUSTER was run on the tenant. It should be empty for active or

nit: do we want to mention "tenant" here?

---

pkg/sql/sem/asof/as_of.go line 19 at r14 (raw file):

	"time"

	apd "github.com/cockroachdb/apd/v3"

nit: seems unnecessary.

---

pkg/sql/parser/testdata/show line 2008 at r11 (raw file):

parse
SHOW VIRTUAL CLUSTER ALL

nit: should we also add CLUSTER_ALL here?

[knz]

what's the rationale for removing some of the syntax from the docs diagrams?

They were not meant to be there in the first place.

what's the end vision for the code base (i.e. non-user-visible) as it relates to the word "tenant"?

To be handled separately (#106069)

Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @stevendanna and @yuzefovich)

---

-- commits line 4 at r1:

Previously, yuzefovich (Yahor Yuzefovich) wrote…

nit: should we rename include_all_secondary_tenants field in jobs.proto too?

This is a code change not UX change so will do as part of #106069

---

pkg/multitenant/mtinfopb/info.proto line 46 at r9 (raw file):

Previously, yuzefovich (Yahor Yuzefovich) wrote…

nit: do we want to mention "tenant" here?

Let's handle this as part of #106069.

---

pkg/sql/parser/testdata/show line 2008 at r11 (raw file):

Previously, yuzefovich (Yahor Yuzefovich) wrote…

nit: should we also add CLUSTER_ALL here?

CLUSTER_ALL is not visible in the syntax; it's a symbolic token in the lexer used to disambiguate the grammar.

[knz]

TFYR!

bors r=yuzefovich

[craig]

Build succeeded:

• Bazel Essential CI (Cockroach)

[blathers-crl]

Encountered an error creating backports. Some common things that can go wrong:

1. The backport branch might have already existed.
2. There was a merge conflict.
3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.

---

error creating merge commit from 874c83b to blathers/backport-release-23.1-106110: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 23.1.x failed. See errors above.

---

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.}