release-23.1: sql: emphasize "virtual cluster" for tenant management in user-facing UX #106376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knz
requested review from
rhu713,
dhartunian and
msirek
and removed request for
a team
|
This change is |
knz
requested review from
stevendanna and
yuzefovich
and removed request for
a team,
rhu713,
dhartunian and
msirek
knz
changed the title
yuzefovich
approved these changes
Jul 7, 2023
|
correct there were virtually none. But I will wait team meeting next week before merging this. |
This aliases `INCLUDE_ALL_SECONDARY_TENANTS` which becomes hidden. Release note: None
Release note: None
This aliases `TENANT_NAME` which becomes hidden. Release note: None
Release note: None
This aliases `TENANT` (in `RESTORE` options) which becomes hidden. Release note: None
Release note: None
Release note: None
Release note: None
Release note: None
Release note: None
Release note: None
…R TENANT`) Release note: None
Release note: None
Release note: None
Release note: None
Release note: None
Release note: None
Before this patch: ``` $ cockroach start-single-node --config-profile=help ... replication-source configuration suitable for a replication source cluster (alias for "multitenant+app+sharedservice+repl") replication-target configuration suitable for a replication target cluster (alias for "multitenant+noapp+repl")` multitenant+app+sharedservice multi-tenant cluster with one secondary tenant configured to serve SQL application traffic multitenant+app+sharedservice+repl multi-tenant cluster with one secondary tenant configured to serve SQL application traffic, with replication enabled multitenant+noapp multi-tenant cluster with no secondary tenant defined yet multitenant+noapp+repl multi-tenant cluster with no secondary tenant defined yet, with replication enabled ``` After this patch: ``` replication-source configuration suitable for a replication source cluster (alias for "virtual+app+sharedservice+repl") replication-target configuration suitable for a replication target cluster (alias for "virtual+noapp+repl") virtual+app+sharedservice one virtual cluster configured to serve SQL application traffic virtual+app+sharedservice+repl one virtual cluster configured to serve SQL application traffic, with replication enabled virtual+noapp virtualization enabled but no virtual cluster defined yet virtual+noapp+repl virtualization enabled but no virtual cluster defined yet, with replication enabled ``` Release note: None
This replaces `disable_drop_tenant`, together with the cluster setting `sql.drop_virtual_cluster.enabled` (replaces `sql.drop_tenant.enabled`). We are OK with this breaking change since the feature was not yet exposed to end-users. Release note: None
…nant" Release note (cluster virtualization): This patch renames the subdirectory inside the output of `cockroach debug zip` when pointed to a cluster with virtualization enabled to be `cluster`, which brings the UX in coherence with the parameter of the same name in `cockroach sql` and the HTTP API parameter in the same name.
knz
force-pushed
the
backport23.1-106110-106116-106121-106298
branch
from
18b829b
to
ff2480d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Informs #106068.
Epic: CRDB-29380
Summary of changes:
disable_drop_tenantrenamed todisable_drop_virtual_clustercluster(previouslytenant).The changes to data structure names, comments etc are on a separate issue (#106069) and will not be backported.
Backport:
disable_drop_virtual_cluster" (sql: session vardisable_drop_virtual_cluster#106121)Please see individual PRs for details.
/cc @cockroachdb/release
Release justification: ensures consistent UX between the 23.1 and 23.2 branches, ensuring there is just 1 UX surface for the doc team to process