-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sql: session var disable_drop_virtual_cluster
#106121
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 12 of 12 files at r1, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @stevendanna)
1038f2f
to
6effeb8
Compare
TFYR! bors r=yuzefovich |
Merge conflict. |
This replaces `disable_drop_tenant`, together with the cluster setting `sql.drop_virtual_cluster.enabled` (replaces `sql.drop_tenant.enabled`). We are OK with this breaking change since the feature was not yet exposed to end-users. Release note: None
6effeb8
to
ab28123
Compare
bors r=yuzefovich |
Build failed (retrying...): |
Build succeeded: |
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from ab28123 to blathers/backport-release-23.1-106121: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 23.1.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Informs #106068.
Epic: CRDB-29380
This replaces
disable_drop_tenant
, together with the cluster settingsql.drop_virtual_cluster.enabled
(replacessql.drop_tenant.enabled
).We are OK with this breaking change since the feature was not yet exposed to end-users.
Release note: None