configprofiles: emphasize "cluster virtualization"

[knz]

Informs #106068.
Epic: CRDB-29380

Before this patch:

$ cockroach start-single-node --config-profile=help
...
replication-source                  configuration suitable for a replication source cluster (alias for "multitenant+app+sharedservice+repl")
replication-target                  configuration suitable for a replication target cluster (alias for "multitenant+noapp+repl")`
multitenant+app+sharedservice       multi-tenant cluster with one secondary tenant configured to serve SQL application traffic
multitenant+app+sharedservice+repl  multi-tenant cluster with one secondary tenant configured to serve SQL application traffic, with replication enabled
multitenant+noapp                   multi-tenant cluster with no secondary tenant defined yet
multitenant+noapp+repl              multi-tenant cluster with no secondary tenant defined yet, with replication enabled

After this patch:

replication-source              configuration suitable for a replication source cluster (alias for "virtual+app+sharedservice+repl")
replication-target              configuration suitable for a replication target cluster (alias for "virtual+noapp+repl")
virtual+app+sharedservice       one virtual cluster configured to serve SQL application traffic
virtual+app+sharedservice+repl  one virtual cluster configured to serve SQL application traffic, with replication enabled
virtual+noapp                   virtualization enabled but no virtual cluster defined yet
virtual+noapp+repl              virtualization enabled but no virtual cluster defined yet, with replication enabled

Release note: None

[cockroach-teamcity]

This change is 

[yuzefovich]

Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @knz and @stevendanna)

---

pkg/configprofiles/profiles.go line 35 at r1 (raw file):

		description: "configuration suitable for a replication target cluster",
	},
	"multitenant+app+sharedservice+repl": {aliasTarget: "virtual+app+sharedservice+repl", hidden: true},

What's the thinking behind keeping these two particular aliases? Is it for backwards-compatibility? Are the config profiles being used somewhere so that we need backwards-compatibility?

[knz]

Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @stevendanna and @yuzefovich)

---

pkg/configprofiles/profiles.go line 35 at r1 (raw file):

Previously, yuzefovich (Yahor Yuzefovich) wrote…

What's the thinking behind keeping these two particular aliases? Is it for backwards-compatibility? Are the config profiles being used somewhere so that we need backwards-compatibility?

Let's simplify. Thanks.

[knz]

TFYR

bors r=yuzefovich

[craig]

Build succeeded:

• Bazel Essential CI (Cockroach)

[blathers-crl]

Encountered an error creating backports. Some common things that can go wrong:

1. The backport branch might have already existed.
2. There was a merge conflict.
3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.

---

error creating merge commit from 8b7f893 to blathers/backport-release-23.1-106116: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 23.1.x failed. See errors above.

---

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.}