Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: use HTTP query parameter cluster for manual selection #106122

Merged
merged 1 commit into from
Jul 5, 2023
Merged

server: use HTTP query parameter cluster for manual selection #106122

merged 1 commit into from
Jul 5, 2023

Conversation

knz
Copy link
Contributor

@knz knz commented Jul 4, 2023

Informs #106068.
Epic: CRDB-29380

Prior to this patch, there was a debug-only way to manually force a HTTP request to be routed to a particular virtual cluster through the server controller. This was achieved via the query parameter tenant_name.

This patch renames the paramater to cluster, for a better UX coherence with the option of the same name in cockroach sql.

Release note: None

@knz
server: use HTTP query parameter cluster for manual selection
48e6310 
Prior to this patch, there was a debug-only way to manually force a
HTTP request to be routed to a particular virtual cluster through the
server controller. This was achieved via the query parameter
`tenant_name`.

This patch renames the paramater to `cluster`, for a better UX
coherence with the option of the same name in `cockroach sql`.

Release note: None
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@knz knz mentioned this pull request Jul 4, 2023
Closed
15 tasks
@knz knz marked this pull request as ready for review July 4, 2023 17:42
@knz knz requested review from a team as code owners July 4, 2023 17:42
@knz knz requested a review from a team July 4, 2023 17:42
@knz knz requested review from a team as code owners July 4, 2023 17:42
@knz knz requested review from herkolategan, smg260 and abarganier and removed request for a team July 4, 2023 17:42
@knz knz added A-multitenancy Related to multi-tenancy backport-23.1.x Flags PRs that need to be backported to 23.1 labels Jul 4, 2023
yuzefovich
yuzefovich approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@yuzefovich yuzefovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @abarganier, @herkolategan, @smg260, and @stevendanna)

@knz
Copy link
Contributor Author

knz commented Jul 5, 2023

TFYR!

bors r=yuzefovich

@craig
Copy link
Contributor

craig bot commented Jul 5, 2023

Build succeeded:

@craig craig bot merged commit e8aedca into cockroachdb:master Jul 5, 2023
2 checks passed
@blathers-crl blathers-crl bot mentioned this pull request Jul 5, 2023
Merged
@blathers-crl
Copy link

blathers-crl bot commented Jul 5, 2023

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.

error setting reviewers, but backport branch blathers/backport-release-23.1-106122 is ready: POST https://api.github.com/repos/cockroachdb/cockroach/pulls/106229/requested_reviewers: 422 Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the cockroachdb/cockroach repository. []

Backport to branch 23.1.x failed. See errors above.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@tbg tbg mentioned this pull request Jul 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuzefovich yuzefovich yuzefovich approved these changes

@stevendanna stevendanna Awaiting requested review from stevendanna

@herkolategan herkolategan Awaiting requested review from herkolategan herkolategan is a code owner automatically assigned from cockroachdb/test-eng

@smg260 smg260 Awaiting requested review from smg260 smg260 is a code owner automatically assigned from cockroachdb/test-eng

@abarganier abarganier Awaiting requested review from abarganier

Assignees
No one assigned
Labels
A-multitenancy Related to multi-tenancy backport-23.1.x Flags PRs that need to be backported to 23.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@knz @cockroach-teamcity @yuzefovich