Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-23.1: server: use HTTP query parameter cluster for manual selection #106229

Merged
merged 1 commit into from
Jul 6, 2023
Merged

release-23.1: server: use HTTP query parameter cluster for manual selection #106229

merged 1 commit into from
Jul 6, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Jul 5, 2023 •
edited by knz
Loading

Backport 1/1 commits from #106122 on behalf of @knz.

/cc @cockroachdb/release

Informs #106068.
Epic: CRDB-29380

Prior to this patch, there was a debug-only way to manually force a HTTP request to be routed to a particular virtual cluster through the server controller. This was achieved via the query parameter tenant_name.

This patch renames the paramater to cluster, for a better UX coherence with the option of the same name in cockroach sql.

Release note: None

Release justification: more coherent UX

@knz
server: use HTTP query parameter cluster for manual selection
cb8fbc6 
Prior to this patch, there was a debug-only way to manually force a
HTTP request to be routed to a particular virtual cluster through the
server controller. This was achieved via the query parameter
`tenant_name`.

This patch renames the paramater to `cluster`, for a better UX
coherence with the option of the same name in `cockroach sql`.

Release note: None
@blathers-crl blathers-crl bot requested review from a team as code owners July 5, 2023 23:01
@blathers-crl blathers-crl bot requested a review from a team July 5, 2023 23:01
@blathers-crl blathers-crl bot requested a review from a team as a code owner July 5, 2023 23:01
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-106122 branch from fa2d7f7 to 1177bfe Compare July 5, 2023 23:01
@blathers-crl blathers-crl bot requested a review from a team as a code owner July 5, 2023 23:01
@blathers-crl blathers-crl bot requested review from herkolategan and smg260 and removed request for a team July 5, 2023 23:01
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Jul 5, 2023
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-106122 branch from 6879c3a to cb8fbc6 Compare July 5, 2023 23:01
@blathers-crl blathers-crl bot requested review from Santamaura and removed request for a team July 5, 2023 23:01
@blathers-crl
Copy link
Author

blathers-crl bot commented Jul 5, 2023 •
edited by knz
Loading

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@knz knz merged commit 05d7d1b into release-23.1 Jul 6, 2023
@knz knz deleted the blathers/backport-release-23.1-106122 branch July 6, 2023 10:12
@knz knz mentioned this pull request Jul 6, 2023
Closed
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knz knz knz approved these changes

@herkolategan herkolategan Awaiting requested review from herkolategan herkolategan is a code owner automatically assigned from cockroachdb/test-eng

@smg260 smg260 Awaiting requested review from smg260 smg260 is a code owner automatically assigned from cockroachdb/test-eng

@Santamaura Santamaura Awaiting requested review from Santamaura

Assignees

@knz knz

Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cockroach-teamcity @knz