-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backupccl: add missing ctx cancel check #111231
Conversation
In cockroachdb#111159 we deduced from the stacks a situation in which the goroutine draining `spanCh` had exited due to a context cancelation but the writer was not listening for a ctx cancelation. This manifests as a stuck restore when using the non-default make simple import spans implementation. Fixes: cockroachdb#111159 Release note: None
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is, in theory, unit test able. but this is also dead, non default code. And we have bigger things on our plate.
the exact thought that went through my head. If it makes sense to you/rui I think I feel pretty good just merging it for now. |
TFTR! bors r=msbutler |
Build succeeded: |
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 6fabaf8 to blathers/backport-release-22.2-111231: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.2.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
In #111159 we deduced from the stacks a
situation in which the goroutine draining
spanCh
had exited due to a context cancelation but thewriter was not listening for a ctx cancelation.
This manifests as a stuck restore when using
the non-default make simple import spans implementation.
Fixes: #111159
Release note: None