Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backupccl: add missing ctx cancel check #111231

Merged
merged 1 commit into from
Sep 25, 2023
Merged

backupccl: add missing ctx cancel check #111231

merged 1 commit into from
Sep 25, 2023

Commits on Sep 25, 2023

  1. backupccl: add missing ctx cancel check 

    In cockroachdb#111159 we deduced from the stacks a
situation in which the goroutine draining `spanCh`
had exited due to a context cancelation but the
writer was not listening for a ctx cancelation.
This manifests as a stuck restore when using
the non-default make simple import spans implementation.

Fixes: cockroachdb#111159
Release note: None
    @adityamaru
    adityamaru committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    6fabaf8 View commit details
    Browse the repository at this point in the history