release-23.2: roachprod: create admin user and backup schedule for virtual clusters #119540
Conversation
This changes `DefaultStartOpts` to use `system` as `VirtualClusterName`. This simplifies the starting logic slightly, as it ensures that the field is always non-empty when starting clusters. When using `roachprod start`, the field will correctly be set to `system`; when using `roachprod start-sql`, the field will be the name of the tenant being started. Epic: none Release note: None
We will soon create default backup schedules for tenants as they are started as well. This flag will allow backup management to be controlled the same way as they currently are for the system tenant. Epic: none Release note: None
This commit updates `roachprod start{-sql}` and unifies the set of
steps performed on the cluster regardless of whether we are starting
the system tenant for the first time or creating a new tenant.
Specifically, tenants will also have an admin user configured and a
default backup schedule is created when `--schedule-backups` is passed.
Epic: none
Release note: None
More concretly, build `StartOpts` based on roachtest's implementation of `DefaultStartOpts`, which includes creating a default backup schedule on start. Epic: none Release note: None
renatolabs
requested review from
herkolategan and
DarrylWong
and removed request for
a team
|
This change is |
renatolabs
changed the title
| // Use the same combination for username and password to allow | ||
| // people using the DB console to easily switch between tenants in | ||
| // the UI, if managing UA clusters. | ||
| const username = DefaultUser |
There was a problem hiding this comment.
It should be okay to stop using roach/system because I don't think any tests in 23.2 are using it in the first place. Does that sound right?
There was a problem hiding this comment.
Yes, that sounds right. As you're well aware, most tests are not be running in secure mode in these branches. Most of the ones that do use the root user; the few tests that don't use root typically use some other user created during the test itself.
This default admin user logic was created not that long ago, and initially had the intention of making it convenient for people creating roachprod clusters to immediately be able to login to the DB console (and, similarly, to log in on clusters after roachtest runs with --debug).
|
Started a sanity 0.1 run and a run of |
|
Both builds ran without errors. TFTR! |
Backport 4/4 commits from #118851.
/cc @cockroachdb/release
Release justification: test only changes.
This commit updates
roachprod start{-sql}and unifies the set ofsteps performed on the cluster regardless of whether we are starting
the system tenant for the first time or creating a new tenant.
Specifically, tenants will also have an admin user configured and a
default backup schedule is created when
--schedule-backupsis passed.Epic: none
Release note: None