roachprod: create admin user and backup schedule for virtual clusters #118851
Conversation
|
This change is |
renatolabs
force-pushed
the
rc/roachprod-admin-and-backup-for-tenants
branch
2 times, most recently
from
5eb5ccc to
3bbaf2b
Compare
renatolabs
requested review from
herkolategan and
srosenberg
and removed request for
a team
|
Ran a couple of builds on this branch:
|
renatolabs
force-pushed
the
rc/roachprod-admin-and-backup-for-tenants
branch
from
3bbaf2b to
c876254
Compare
|
Rebased to fix conflicts with recent changes. Worth noting is that I changed the default username/password combination from I'll run a few test runs on this branch, I'm curious if there were any other assumptions on the previous credentials that we missed. |
This changes `DefaultStartOpts` to use `system` as `VirtualClusterName`. This simplifies the starting logic slightly, as it ensures that the field is always non-empty when starting clusters. When using `roachprod start`, the field will correctly be set to `system`; when using `roachprod start-sql`, the field will be the name of the tenant being started. Epic: none Release note: None
We will soon create default backup schedules for tenants as they are started as well. This flag will allow backup management to be controlled the same way as they currently are for the system tenant. Epic: none Release note: None
This commit updates `roachprod start{-sql}` and unifies the set of
steps performed on the cluster regardless of whether we are starting
the system tenant for the first time or creating a new tenant.
Specifically, tenants will also have an admin user configured and a
default backup schedule is created when `--schedule-backups` is passed.
Epic: none
Release note: None
More concretly, build `StartOpts` based on roachtest's implementation of `DefaultStartOpts`, which includes creating a default backup schedule on start. Epic: none Release note: None
renatolabs
force-pushed
the
rc/roachprod-admin-and-backup-for-tenants
branch
from
c876254 to
3d1995a
Compare
|
Ran a final run on this branch; failures are unrelated and also happen on master. TFTR! bors r=herkolategan |
|
Build succeeded: |
|
This has been running without problems on master, so I'll attempt to backport it. blathers backport 23.2 23.1 |
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 3cdcfe8 to blathers/backport-release-23.2-118851: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 23.2 failed. See errors above. error creating merge commit from 3cdcfe8 to blathers/backport-release-23.1-118851: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 23.1 failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
This commit updates
roachprod start{-sql}and unifies the set ofsteps performed on the cluster regardless of whether we are starting
the system tenant for the first time or creating a new tenant.
Specifically, tenants will also have an admin user configured and a
default backup schedule is created when
--schedule-backupsis passed.Epic: none
Release note: None