backport-2.1: server: add a configuration to enable GC of system.rangelog #31328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
I don't think we should have this on by default in 2.1. Either leave it for 2.2 or backport it with the default changed to 0. |
system.rangelog table currently grows unboundedly. The rate of growth is slow (as long as there is no replica rebalancing thrashing), but it can still become a problem in long running clusters. This commit adds cluster settings to specify interval and TTL for rows in system.rangelog. By default, TTL of system.rangelog is set to 30 days, and that for system.eventlog to 90 days. Fixes cockroachdb#21260. Release note (sql change): the range log and system events logs will automatically purge records older than 30 and 90 days, respectively. This can be adjusted via the server.rangelog.ttl and server.eventlog.ttl cluster settings.
Using transaction timstamp can lead to flaky tests. Use constant timestamps while inserting events in rangelog gc test. Fixes cockroachdb#31371. Release note: None
It's too late in the cycle to have these on by default (in release-2.1), but they're good to have in our back pockets. Release note: None
tbg
force-pushed
the
backport2.1-30913
branch
from
54b55c6
to
b9c84d4
Compare
|
Updated, PTAL. |
|
LGTM, but now that RC1 has been cut I don't feel comfortable adding this at this point. Maybe in a patch release, but I think I'd prefer waiting for 2.2. |
|
Ack. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #30913.
This doesn't have to be in 2.1, and it hasn't baked particularly long, so I'm open to not backporting this (though I think it's a useful feature and due to the kill switch it can be disarmed)
Maybe we should backport this with a TTLs of zero (disabled)?
/cc @cockroachdb/release
system.rangelog table currently grows unboundedly. The rate of
growth is slow (as long as there is no replica rebalancing
thrashing), but it can still become a problem in long running
clusters.
This commit adds cluster settings to specify interval and TTL
for rows in system.rangelog.
By default, TTL of system.rangelog is set to 30 days.
Fixes #21260
Release note: Add configuration to enable GC of system.rangelog