Commits on Feb 20, 2019

1. intentresolver: fix testrace flake by extending timeouts …

   The unit tests which failed assumed that all messages intents in a single call
   to ResolveIntents could be queued within the batch timeout and idle window which
   is by default rather short (10 and 5 ms respectively). The testing validation
   logic is rather strict and assumes that the batch will fire due to size rather
   than time constraints. The fix is to allow the test to increase these values to
   make the test more robust to load. Before this change the flake was reproducible
   running testrace within several hundred iterations. Running testrace now seems
   to not provoke any failures.
   
   All that being said, I can see an argument that the testing logic should be
   made less rigid and should accept that the batches may be split up.
   
   Fixes cockroachdb#35064.
   
   Release note: None

   

   ajwerner committed Feb 20, 2019
   Configuration menu

   • View commit details
   • Copy full SHA for 7fdc815
   • Browse repository at this point

   Copy the full SHA

   7fdc815 View commit details

   Browse the repository at this point in the history