coldata: fix Slice when slicing up to batch.Length() #36872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A panic occured because we weren't treating the end slice index as exclusive, resulting in an out of bounds panic when attempting to slice the nulls slice. Release note: None
|
This change is |
yuzefovich
approved these changes
Apr 16, 2019
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained
|
bors r=yuzefovich |
craig bot
pushed a commit
that referenced
this pull request
Apr 16, 2019
36804: sql/sem/pretty: use left alignment for column names in CREATE r=knz a=knz
Before:
```
CREATE TABLE t (
name STRING,
id INT8
NOT NULL
PRIMARY KEY
)
```
After:
```
CREATE TABLE t (
name STRING,
id INT8
NOT NULL
PRIMARY KEY
)
```
36852: changefeedccl: switch retryable errors back to a whitelist r=nvanbenschoten a=danhhz
For a while, the cdc/crdb-chaos and cdc/sink-chaos roachtests have been
failing because an error that should be marked as retryable wasn't. As a
result of the discussion in #35974, I tried switching from a whitelist
(retryable error) to a blacklist (terminal error) in #36132, but on
reflection this doesn't seem like a great idea. We added a safety net to
prevent false negatives from retrying indefinitely but it was
immediately apparent that this meant we needed to tune the retry loop
parameters. Better is to just do the due diligence of investigating the
errors that should be retried and retrying them.
The commit is intended for backport into 19.1 once it's baked for a bit.
Closes #35974
Closes #36018
Closes #36019
Closes #36432
Release note (bug fix): `CHANGEFEED` now retry instead of erroring in
more situations
36872: coldata: fix Slice when slicing up to batch.Length() r=yuzefovich a=asubiotto
A panic occured because we weren't treating the end slice index as
exclusive, resulting in an out of bounds panic when attempting to slice
the nulls slice.
Release note: None
Co-authored-by: Raphael 'kena' Poss <knz@cockroachlabs.com>
Co-authored-by: Daniel Harrison <daniel.harrison@gmail.com>
Co-authored-by: Alfonso Subiotto Marqués <alfonso@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A panic occured because we weren't treating the end slice index as
exclusive, resulting in an out of bounds panic when attempting to slice
the nulls slice.
Release note: None