storage: reintroduce building SSTs from KV_BATCH snapshot #39689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ngestion fix Pick up cockroachdb/rocksdb#43. Release note: None
|
This change is |
|
Nit: can you make the commit reintroducing the snapshot logic a revert of my revert? You can get this by dropping your commit and running I typically leave the "revert" line alone so that it's obvious to readers that you're not checking in new code. |
tbg
approved these changes
Aug 15, 2019
jeffrey-xiao
force-pushed
the
sst-snapshot
branch
from
edc0988
to
49f9470
Compare
jeffrey-xiao
force-pushed
the
sst-snapshot
branch
from
49f9470
to
86411ba
Compare
nvanbenschoten
approved these changes
Aug 15, 2019
|
TFTRs! bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Aug 15, 2019
39689: storage: reintroduce building SSTs from KV_BATCH snapshot r=jeffrey-xiao a=jeffrey-xiao The final commit of #38932 was previously reverted to due an underlying bug in RocksDB with ingesting range deletion tombstones with a global seqno. See #39604 for discussion on the bug and cockroachdb/rocksdb#43 for the temporary short-term resolution of the bug. Release note: None Co-authored-by: Jeffrey Xiao <jeffrey.xiao1998@gmail.com>
Build succeeded |
jeffrey-xiao
added a commit
to jeffrey-xiao/cockroach
that referenced
this pull request
Aug 15, 2019
This was referenced Aug 15, 2019
jeffrey-xiao
added a commit
to jeffrey-xiao/cockroach
that referenced
this pull request
Aug 16, 2019
This reverts commit 467ba10. Release note: None
nvanbenschoten
added a commit
to nvanbenschoten/cockroach
that referenced
this pull request
Sep 17, 2019
This reverts commit 324151e. Release note: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The final commit of #38932 was previously reverted to due an underlying bug in RocksDB with ingesting range deletion tombstones with a global seqno. See #39604 for discussion on the bug and cockroachdb/rocksdb#43 for the temporary short-term resolution of the bug.
Release note: None