Fix range deletion tombstone ingestion with global seqno #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we are writing a global seqno for an ingested file, the range tombstone meta-block gets accessed and put in the block cache during ingestion preparation. At the time, the global seqno has not been determined so the cached block does not have a global seqno. When the file's ingested and we read its range tombstone meta-block, it will be returned from the cache with no global seqno. In that case, we use the actual seqnos stored in the range tombstones, which are all zero, so the tombstones cover nothing. This commit adds a flag to disable filling the cache when the range tombstone meta-block is accessed for the first time and adds a regression test for the bug.
|
With this change, |
nvanbenschoten
approved these changes
Aug 14, 2019
|
See cockroachdb/cockroach#39604 (comment) which suggests another approach which may fix a related bug. (I'm not sure that related bug exists). |
ajkr
approved these changes
Aug 14, 2019
There was a problem hiding this comment.
Reviewed 17 of 17 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
jeffrey-xiao
added a commit
to jeffrey-xiao/cockroach
that referenced
this pull request
Aug 15, 2019
…ngestion fix Pick up cockroachdb/rocksdb#43. Release note: None
craig bot
pushed a commit
to cockroachdb/cockroach
that referenced
this pull request
Aug 15, 2019
39689: storage: reintroduce building SSTs from KV_BATCH snapshot r=jeffrey-xiao a=jeffrey-xiao The final commit of #38932 was previously reverted to due an underlying bug in RocksDB with ingesting range deletion tombstones with a global seqno. See #39604 for discussion on the bug and cockroachdb/rocksdb#43 for the temporary short-term resolution of the bug. Release note: None Co-authored-by: Jeffrey Xiao <jeffrey.xiao1998@gmail.com>
jeffrey-xiao
deleted the
jeffreyxiao/fix-range-deletion-tombstone-global-seqno-caching
branch
jeffrey-xiao
added a commit
to jeffrey-xiao/cockroach
that referenced
this pull request
Aug 16, 2019
Pick up cockroachdb/rocksdb#43 and cockroachdb/rocksdb#44. Release note: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we are writing a global seqno for an ingested file, the range tombstone meta-block gets accessed and put in the block cache during ingestion preparation. At the time, the global seqno has not been
determined so the cached block does not have a global seqno. When the file's ingested and we read its range tombstone meta-block, it will be returned from the cache with no global seqno. In that case, we use the actual seqnos stored in the range tombstones, which are all zero, so the
tombstones cover nothing.
This commit adds a flag to disable filling the cache when the range tombstone meta-block is accessed for the first time and adds a regression test for the bug.
This change is