Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix range deletion tombstone ingestion with global seqno #43

Merged
merged 1 commit into from
Aug 15, 2019
Merged

Fix range deletion tombstone ingestion with global seqno #43

merged 1 commit into from
Aug 15, 2019

Commits on Aug 14, 2019

  1. Fix range deletion tombstone ingestion with global seqno 

    If we are writing a global seqno for an ingested file, the range
tombstone meta-block gets accessed and put in the block cache during
ingestion preparation. At the time, the global seqno has not been
determined so the cached block does not have a global seqno. When the
file's ingested and we read its range tombstone meta-block, it will be
returned from the cache with no global seqno. In that case, we use the
actual seqnos stored in the range tombstones, which are all zero, so the
tombstones cover nothing.

This commit adds a flag to disable filling the cache when the range
tombstone meta-block is accessed for the first time and adds a
regression test for the bug.
    @jeffrey-xiao
    jeffrey-xiao committed Aug 14, 2019
    Configuration menu
    Copy the full SHA
    6ddbda8 View commit details
    Browse the repository at this point in the history