storage: don't panic on absent store in StorePool.getStoreListFromIDs #40645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes cockroachdb#40598. The store ID filter is passed to the StorePool from outside of the lock, so it's possible that the removal of the store from the StorePool raced with the goroutine calling getStoreListFromIDs. This should be handled by ignoring the StoreID, which is already the case if a store is found with the status `storeStatusDead`, `storeStatusUnknown`, or `storeStatusDecommissioning`. Will need to be backported to 19.1 and 2.1. Release note: None
|
This change is |
andreimatei
reviewed
Sep 11, 2019
There was a problem hiding this comment.
LGTM
good find
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @andreimatei)
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Sep 11, 2019
40645: storage: don't panic on absent store in StorePool.getStoreListFromIDs r=nvanbenschoten a=nvanbenschoten Fixes #40598. The store ID filter is passed to the StorePool from outside of the lock, so it's possible that the removal of the store from the StorePool raced with the goroutine calling getStoreListFromIDs. This should be handled by ignoring the StoreID, which is already the case if a store is found with the status `storeStatusDead`, `storeStatusUnknown`, or `storeStatusDecommissioning`. Will need to be backported to 19.1 and 2.1. Release note: None Co-authored-by: Nathan VanBenschoten <nvanbenschoten@gmail.com>
Build succeeded |
This was referenced Sep 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40598.
The store ID filter is passed to the StorePool from outside of the lock,
so it's possible that the removal of the store from the StorePool raced
with the goroutine calling getStoreListFromIDs. This should be handled
by ignoring the StoreID, which is already the case if a store is found
with the status
storeStatusDead,storeStatusUnknown, orstoreStatusDecommissioning.Will need to be backported to 19.1 and 2.1.
Release note: None