release-19.1: storage: don't panic on absent store in StorePool.getStoreListFromIDs #40678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes cockroachdb#40598. The store ID filter is passed to the StorePool from outside of the lock, so it's possible that the removal of the store from the StorePool raced with the goroutine calling getStoreListFromIDs. This should be handled by ignoring the StoreID, which is already the case if a store is found with the status `storeStatusDead`, `storeStatusUnknown`, or `storeStatusDecommissioning`. Will need to be backported to 19.1 and 2.1. Release note: None
|
This change is |
|
LGTM
…On Wed, Sep 11, 2019 at 1:20 PM cockroach-teamcity ***@***.***> wrote:
This change is [image: Reviewable]
<https://reviewable.io/reviews/cockroachdb/cockroach/40678>
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#40678?email_source=notifications&email_token=AAC4C4PSVBJGZTIQBCRZ4F3QJESGBA5CNFSM4IVWV53KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6PHNKI#issuecomment-530478761>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAC4C4KIFLWZMATVCPP4J73QJESGBANCNFSM4IVWV53A>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #40645.
/cc @cockroachdb/release
Fixes #40598.
The store ID filter is passed to the StorePool from outside of the lock,
so it's possible that the removal of the store from the StorePool raced
with the goroutine calling getStoreListFromIDs. This should be handled
by ignoring the StoreID, which is already the case if a store is found
with the status
storeStatusDead,storeStatusUnknown, orstoreStatusDecommissioning.Will need to be backported to 19.1 and 2.1.
Release note: None