roachtest: limit number of workers for schemachange tests #40924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With `--wait=false`, tpcc defaults to `10*W` workers and connections. The opt catalog objects are per-connection, so this ends up using a lot of memory. The schema change part makes it worse because we keep multiple versions of the changed tables. Reduce the number of connections in the tests, at least until we implement sharing of opt catalog objects between connections. Fixes cockroachdb#40566. Release justification: non-production code change. Release note: None
|
This change is |
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Sep 19, 2019
40924: roachtest: limit number of workers for schemachange tests r=RaduBerinde a=RaduBerinde With `--wait=false`, tpcc defaults to `10*W` workers and connections. The opt catalog objects are per-connection, so this ends up using a lot of memory. The schema change part makes it worse because we keep multiple versions of the changed tables. Reduce the number of connections in the tests, at least until we implement sharing of opt catalog objects between connections. Fixes #40566. Release justification: non-production code change. Release note: None Co-authored-by: Radu Berinde <radu@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
--wait=false, tpcc defaults to10*Wworkers and connections.The opt catalog objects are per-connection, so this ends up using a
lot of memory. The schema change part makes it worse because we keep
multiple versions of the changed tables.
Reduce the number of connections in the tests, at least until we
implement sharing of opt catalog objects between connections.
Fixes #40566.
Release justification: non-production code change.
Release note: None