Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: limit number of workers for schemachange tests #40924

Merged
merged 1 commit into from
Sep 19, 2019
Merged

roachtest: limit number of workers for schemachange tests #40924

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions pkg/cmd/roachtest/schemachange.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,9 @@ func makeIndexAddTpccTest(spec clusterSpec, warehouses int, length time.Duration
Run: func(ctx context.Context, t *test, c *cluster) {
runTPCC(ctx, t, c, tpccOptions{
Warehouses: warehouses,
Extra: "--wait=false --tolerate-errors",
// We limit the number of workers because the default results in a lot
// of connections which can lead to OOM issues (see #40566).
Extra: fmt.Sprintf("--wait=false --tolerate-errors --workers=%d", warehouses),
During: func(ctx context.Context) error {
return runAndLogStmts(ctx, t, c, "addindex", []string{
`CREATE UNIQUE INDEX ON tpcc.order (o_entry_d, o_w_id, o_d_id, o_carrier_id, o_id);`,
Expand Down Expand Up @@ -409,7 +411,9 @@ func makeMixedSchemaChanges(spec clusterSpec, warehouses int, length time.Durati
Run: func(ctx context.Context, t *test, c *cluster) {
runTPCC(ctx, t, c, tpccOptions{
Warehouses: warehouses,
Extra: "--wait=false --tolerate-errors",
// We limit the number of workers because the default results in a lot
// of connections which can lead to OOM issues (see #40566).
Extra: fmt.Sprintf("--wait=false --tolerate-errors --workers=%d", warehouses),
During: func(ctx context.Context) error {
if t.IsBuildVersion(`v19.2.0`) {
if err := runAndLogStmts(ctx, t, c, "mixed-schema-changes-19.2", []string{
Expand Down