colrpc: downgrade log messages from Error to Warning #41174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
Wondering whether I should keep the data serialization errors as |
|
Addresses #36981 |
yuzefovich
approved these changes
Oct 3, 2019
There was a problem hiding this comment.
Errors.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @jordanlewis)
Outbox/Inbox failures mostly result in query failures, which aren't severe enough to use the ERROR level. Additionally, some potentially spammy log messages have been put behind a verbosity check. Release note: None Release justification: Category 4 low-risk change to existing functionality by reducing log message spam.
|
Done. cc @jordanlewis in case you want to take a quick look bors r=yuzefovich |
craig bot
pushed a commit
that referenced
this pull request
Oct 9, 2019
41174: colrpc: downgrade log messages from Error to Warning r=yuzefovich a=asubiotto Outbox/Inbox failures mostly result in query failures, which aren't severe enough to use the ERROR level. Additionally, some potentially spammy log messages have been put behind a verbosity check. Release note: None Release justification: Category 4 low-risk change to existing functionality by reducing log message spam. Co-authored-by: Alfonso Subiotto Marqués <alfonso@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Outbox/Inbox failures mostly result in query failures, which aren't
severe enough to use the ERROR level. Additionally, some potentially
spammy log messages have been put behind a verbosity check.
Release note: None
Release justification: Category 4 low-risk change to existing
functionality by reducing log message spam.