opt: fix hidden column handling for WITH #41187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove hidden columns from CTE sources. Statements that return hidden columns are rare but they do exist (EXPLAIN, SHOW ZONE CONFIGURATION). When used as a CTE, these hidden columns should be removed. Also making a small fix to `removeHiddenCols`: it's not ok to remove a hidden column if it is referenced by the ordering; now we move the hidden columns to `extraCols` instead. I could not come up with an example where this was a problem with the current uses. Release justification: low-cost fix to new functionality. Release note: None
|
This change is |
justinj
reviewed
Sep 30, 2019
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @justinj, @RaduBerinde, and @rytaft)
pkg/sql/opt/optbuilder/testdata/with, line 768 at r1 (raw file):
# Check hidden column handling: level, node_type should not be output. build WITH cte AS (EXPLAIN (VERBOSE) SELECT 1) SELECT * FROM cte
this is allowed??
RaduBerinde
commented
Sep 30, 2019
There was a problem hiding this comment.
Reviewable status:
pkg/sql/opt/optbuilder/testdata/with, line 768 at r1 (raw file):
Previously, justinj (Justin Jaffray) wrote…
this is allowed??
Yeah.. We could trim down the list of supported statements, but I think it's valuable to support at least everything that [ ... ] supports so there aren't cases where you're forced to use the bracket syntax.
|
bors r+ |
1 similar comment
|
bors r+ |
Build failed |
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Oct 1, 2019
41187: opt: fix hidden column handling for WITH r=RaduBerinde a=RaduBerinde Remove hidden columns from CTE sources. Statements that return hidden columns are rare but they do exist (EXPLAIN, SHOW ZONE CONFIGURATION). When used as a CTE, these hidden columns should be removed. Also making a small fix to `removeHiddenCols`: it's not ok to remove a hidden column if it is referenced by the ordering; now we move the hidden columns to `extraCols` instead. I could not come up with an example where this was a problem with the current uses. Release justification: low-cost fix to new functionality. Release note: None Co-authored-by: Radu Berinde <radu@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove hidden columns from CTE sources. Statements that return hidden
columns are rare but they do exist (EXPLAIN, SHOW ZONE CONFIGURATION).
When used as a CTE, these hidden columns should be removed.
Also making a small fix to
removeHiddenCols: it's not ok to remove ahidden column if it is referenced by the ordering; now we move the
hidden columns to
extraColsinstead. I could not come up with anexample where this was a problem with the current uses.
Release justification: low-cost fix to new functionality.
Release note: None