Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opt: fix hidden column handling for WITH #41187

Merged
merged 1 commit into from
Oct 1, 2019
Merged

opt: fix hidden column handling for WITH #41187

merged 1 commit into from
Oct 1, 2019

Commits on Sep 29, 2019

  1. opt: fix hidden column handling for WITH 

    Remove hidden columns from CTE sources. Statements that return hidden
columns are rare but they do exist (EXPLAIN, SHOW ZONE CONFIGURATION).
When used as a CTE, these hidden columns should be removed.

Also making a small fix to `removeHiddenCols`: it's not ok to remove a
hidden column if it is referenced by the ordering; now we move the
hidden columns to `extraCols` instead. I could not come up with an
example where this was a problem with the current uses.

Release justification: low-cost fix to new functionality.

Release note: None
    @RaduBerinde
    RaduBerinde committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    120a07e View commit details
    Browse the repository at this point in the history