libroach: Don't assert on nonzero min timestamp hints in iterators #41217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, if either a min or max timestamp hint is provided to a RocksDB iterator, we assert that both are non-zero. In practice, we only need to assert on the max one being nonzero; a zero min timestamp hint when encoded would sort before all timestamps, and would not filter out any SSTs. A zero max timestamp hint could filter out all SSTs, which would be worth asserting on. Fixes cockroachdb#41200 . Release justification: Fixes assertions that are currently failing in tests, no risk otherwise. Release note: None
|
This change is |
|
For reference, here's the only place timestamp hints are used: https://github.com/cockroachdb/cockroach/blob/master/c-deps/libroach/iterator.cc#L51 |
dt
approved these changes
Sep 30, 2019
petermattis
approved these changes
Sep 30, 2019
There was a problem hiding this comment.
So has this been broken "forever" and we just never noticed because of not having asserts enabled?
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @dt and @petermattis)
|
Seems like it. That assertion has been there for at least a year. Thanks for the review! bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Sep 30, 2019
41217: libroach: Don't assert on nonzero min timestamp hints in iterators r=itsbilal a=itsbilal Currently, if either a min or max timestamp hint is provided to a RocksDB iterator, we assert that both are non-zero. In practice, we only need to assert on the max one being nonzero; a zero min timestamp hint when encoded would sort before all timestamps, and would not filter out any SSTs. A zero max timestamp hint could filter out all SSTs, which would be worth asserting on. Fixes #41200 . Release justification: Fixes assertions that are currently failing in tests, no risk otherwise. Release note: None Co-authored-by: Bilal Akhtar <bilal@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if either a min or max timestamp hint is provided to a
RocksDB iterator, we assert that both are non-zero. In practice,
we only need to assert on the max one being nonzero; a zero min
timestamp hint when encoded would sort before all timestamps, and
would not filter out any SSTs. A zero max timestamp
hint could filter out all SSTs, which would be worth asserting on.
Fixes #41200 .
Release justification: Fixes assertions that are currently failing
in tests, no risk otherwise.
Release note: None