Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libroach: Don't assert on nonzero min timestamp hints in iterators #41217

Merged
merged 1 commit into from
Sep 30, 2019

Commits on Sep 30, 2019

  1. libroach: Don't assert on nonzero min timestamp hints in iterators

    Currently, if either a min or max timestamp hint is provided to a
    RocksDB iterator, we assert that both are non-zero. In practice,
    we only need to assert on the max one being nonzero; a zero min
    timestamp hint when encoded would sort before all timestamps, and
    would not filter out any SSTs. A zero max timestamp
    hint could filter out all SSTs, which would be worth asserting on.
    
    Fixes cockroachdb#41200 .
    
    Release justification: Fixes assertions that are currently failing
    in tests, no risk otherwise.
    
    Release note: None
    itsbilal committed Sep 30, 2019
    Configuration menu
    Copy the full SHA
    d5a1bf7 View commit details
    Browse the repository at this point in the history