-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sql: remove TODO about #13642 & revert unintentional math function changes #48014
Conversation
Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR. Before a member of our team reviews your PR, I have a few suggestions for tidying it up for review:
I was unable to automatically find a reviewer. You can try CCing one of the following members:
🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
❌ The GitHub CI (Cockroach) build has failed on 12424f0b. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
cockroachdb#47627 seems to have made an unintended function change during the rebase. Release note: None
This issue already fixed. Release note: None
Thank you for updating your pull request. Before a member of our team reviews your PR, I have a few suggestions for tidying it up for review:
I was unable to automatically find a reviewer. You can try CCing one of the following members:
🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of nits: we usually don't have periods in the PR titles, and the PR description is missing
Reviewed 1 of 1 files at r1, 2 of 2 files at r2.
Reviewable status: complete! 1 of 0 LGTMs obtained
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the review!
Reviewable status: complete! 1 of 0 LGTMs obtained
bors r=yuzefovich |
Build failed |
CI flake. bors r=yuzefovich |
Build succeeded |
The title says it all.