Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: remove TODO about #13642 & revert unintentional math function changes #48014

Merged
merged 2 commits into from
Apr 25, 2020

Conversation

hueypark
Copy link
Contributor

@hueypark hueypark commented Apr 24, 2020

The title says it all.

@blathers-crl
Copy link

blathers-crl bot commented Apr 24, 2020

Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR.

Before a member of our team reviews your PR, I have a few suggestions for tidying it up for review:

  • We generally try and keep pull requests to one commit. Please squash your commits, and re-push with --force.
  • Please ensure your pull request description contains a release note - this can be the same as the one in your commit message.
  • When CI has completed, please ensure no errors have appeared.

I was unable to automatically find a reviewer. You can try CCing one of the following members:

  • A person you worked with closely on this PR.
  • The person who created the ticket, or a CRDB organization member involved with the ticket (author, commenter, etc.).
  • Join our community slack channel and ask on #contributors.
  • Try find someone else from here.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@blathers-crl
Copy link

blathers-crl bot commented Apr 24, 2020

❌ The GitHub CI (Cockroach) build has failed on 12424f0b.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

cockroachdb#47627 seems to have made an unintended function change during the rebase.

Release note: None
This issue already fixed.

Release note: None
@blathers-crl
Copy link

blathers-crl bot commented Apr 24, 2020

Thank you for updating your pull request.

Before a member of our team reviews your PR, I have a few suggestions for tidying it up for review:

  • We generally try and keep pull requests to one commit. Please squash your commits, and re-push with --force.
  • Please ensure your pull request description contains a release note - this can be the same as the one in your commit message.
  • When CI has completed, please ensure no errors have appeared.

I was unable to automatically find a reviewer. You can try CCing one of the following members:

  • A person you worked with closely on this PR.
  • The person who created the ticket, or a CRDB organization member involved with the ticket (author, commenter, etc.).
  • Join our community slack channel and ask on #contributors.
  • Try find someone else from here.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@yuzefovich yuzefovich self-requested a review April 24, 2020 14:15
Copy link
Member

@yuzefovich yuzefovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! :lgtm:

A couple of nits: we usually don't have periods in the PR titles, and the PR description is missing

Reviewed 1 of 1 files at r1, 2 of 2 files at r2.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@hueypark hueypark changed the title sql: remove TODO about #13642 & revert unintentional math function changes. sql: remove TODO about #13642 & revert unintentional math function changes Apr 24, 2020
Copy link
Contributor Author

@hueypark hueypark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the review!

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@yuzefovich
Copy link
Member

bors r=yuzefovich

@craig
Copy link
Contributor

craig bot commented Apr 24, 2020

Build failed

@yuzefovich
Copy link
Member

CI flake.

bors r=yuzefovich

@craig
Copy link
Contributor

craig bot commented Apr 25, 2020

Build succeeded

@craig craig bot merged commit d620f62 into cockroachdb:master Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants