Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clusterversion: Move JoinTokensTable,AcquisitionTypeInLeaseHistory to 21.2 #64413

Merged
merged 1 commit into from
May 1, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/generated/settings/settings-for-tenants.txt
Original file line number Diff line number Diff line change
Expand Up @@ -105,4 +105,4 @@ trace.datadog.project string CockroachDB the project under which traces will be
trace.debug.enable boolean false if set, traces for recent requests can be seen at https://<ui>/debug/requests
trace.lightstep.token string if set, traces go to Lightstep using this token
trace.zipkin.collector string if set, traces go to the given Zipkin instance (example: '127.0.0.1:9411'). Only one tracer can be configured at a time.
version version 21.1-2 set the active cluster version in the format '<major>.<minor>'
version version 21.1-6 set the active cluster version in the format '<major>.<minor>'
2 changes: 1 addition & 1 deletion docs/generated/settings/settings.html
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,6 @@
<tr><td><code>trace.debug.enable</code></td><td>boolean</td><td><code>false</code></td><td>if set, traces for recent requests can be seen at https://<ui>/debug/requests</td></tr>
<tr><td><code>trace.lightstep.token</code></td><td>string</td><td><code></code></td><td>if set, traces go to Lightstep using this token</td></tr>
<tr><td><code>trace.zipkin.collector</code></td><td>string</td><td><code></code></td><td>if set, traces go to the given Zipkin instance (example: '127.0.0.1:9411'). Only one tracer can be configured at a time.</td></tr>
<tr><td><code>version</code></td><td>version</td><td><code>21.1-2</code></td><td>set the active cluster version in the format '<major>.<minor>'</td></tr>
<tr><td><code>version</code></td><td>version</td><td><code>21.1-6</code></td><td>set the active cluster version in the format '<major>.<minor>'</td></tr>
</tbody>
</table>
30 changes: 15 additions & 15 deletions pkg/clusterversion/cockroach_versions.go
Original file line number Diff line number Diff line change
Expand Up @@ -275,20 +275,20 @@ const (
// ProtectedTsMetaPrivilegesMigration is for the migration which fixes the
// privileges of the protected_ts_meta system table.
ProtectedTsMetaPrivilegesMigration
// JoinTokensTable adds the system table for storing ephemeral generated
// join tokens.
JoinTokensTable
// AcquisitionTypeInLeaseHistory augments the per-replica lease history to
// include the type of lease acquisition event that resulted in that replica's
// current lease.
AcquisitionTypeInLeaseHistory
// V21_1 is CockroachDB v21.1. It's used for all v21.1.x patch releases.
V21_1

// v21.2 versions.
//
// Start21_2 demarcates work towards CockroachDB v21.2.
Start21_2
// JoinTokensTable adds the system table for storing ephemeral generated
// join tokens.
JoinTokensTable
// AcquisitionTypeInLeaseHistory augments the per-replica lease history to
// include the type of lease acquisition event that resulted in that replica's
// current lease.
AcquisitionTypeInLeaseHistory

// Step (1): Add new versions here.
)
Expand Down Expand Up @@ -491,14 +491,6 @@ var versionsSingleton = keyedVersions([]keyedVersion{
Key: ProtectedTsMetaPrivilegesMigration,
Version: roachpb.Version{Major: 20, Minor: 2, Internal: 48},
},
{
Key: JoinTokensTable,
Version: roachpb.Version{Major: 20, Minor: 2, Internal: 50},
},
{
Key: AcquisitionTypeInLeaseHistory,
Version: roachpb.Version{Major: 20, Minor: 2, Internal: 52},
},
{
// V21_1 is CockroachDB v21.1. It's used for all v21.1.x patch releases.
Key: V21_1,
Expand All @@ -510,6 +502,14 @@ var versionsSingleton = keyedVersions([]keyedVersion{
Key: Start21_2,
Version: roachpb.Version{Major: 21, Minor: 1, Internal: 2},
},
{
Key: JoinTokensTable,
Version: roachpb.Version{Major: 21, Minor: 1, Internal: 4},
},
{
Key: AcquisitionTypeInLeaseHistory,
Version: roachpb.Version{Major: 21, Minor: 1, Internal: 6},
},

// Step (2): Add new versions here.
})
Expand Down
12 changes: 6 additions & 6 deletions pkg/clusterversion/key_string.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.