backupccl: deflake TestBackupRestoreSystemJobProgress #68961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
I've got |
In the case of backup we only update the jobs fraction progressed if we have exported a complete span. This change adds some logic to wait until atleast one complete span has been exported, before checking for a progress update. Release note: None
adityamaru
force-pushed
the
skip-test-progress
branch
from
7df92cc
to
4dcd54c
Compare
pbardea
approved these changes
Aug 16, 2021
|
Yeah, I'm inclined to bors this for now to unclog CI. TFTR! bors r=pbardea |
|
Build succeeded: |
craig bot
pushed a commit
that referenced
this pull request
Aug 16, 2021
68812: randgen: generate random expression indexes r=mgartner a=mgartner #### randgen: refactor random expression generation This commit refactors the code that generates random computed columns so that the logic for generating random expressions can be used in a future commit to generate random expression indexes. Release note: None #### randgen: generate random expression indexes The `randgen` package now generates schemas with random expression indexes. This allows for random testing of expression indexes in `sqlsmith` and ternary logic partitioning (TLP). Fixes #68174 Release note: None 68918: Revert "streamingccl: hang processors on losing connection with sinkless stream client" r=arulajmani a=adityamaru This reverts commit f5244f4. 68990: roachtest/tests: adjust sqlsmith slightly r=yuzefovich a=yuzefovich This commit adjusts `sqlsmith` roachtest slightly so that vectorized panic injection occurs with 50% probability (instead of 100%). This is done to check whether the panic injection is the root cause of the inbox communication errors we have been seeing sporadically. Informs: #66174. Release note: None 69003: backupccl: skip TestBackupRestoreSystemJobProgress under stressrace r=arulajmani a=adityamaru The test times out under stressrace. It runs without flaking under `stress` after #68961. Release note: None Co-authored-by: Marcus Gartner <marcus@cockroachlabs.com> Co-authored-by: Aditya Maru <adityamaru@gmail.com> Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case of backup we only update the jobs fraction
progressed if we have exported a complete span. This
change adds some logic to wait until atleast one complete
span has been exported, before checking for a progress update.
Release note: None