Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-21.2: ui: keep state of selections on database page #73989

Merged
merged 3 commits into from
Dec 21, 2021
Merged

release-21.2: ui: keep state of selections on database page #73989

merged 3 commits into from
Dec 21, 2021

Conversation

maryliag
Copy link
Contributor

@maryliag maryliag commented Dec 17, 2021 •
edited
Loading

Backport:

Please see individual PRs for details.

/cc @cockroachdb/release

Release justification: Category 4

@maryliag
ui: save sort settings on cache for Database page
3eb3d65 
Previously, sort setting on Databases page were not
being stored. With this commits we save the info about sort settings,
so the value is the same when the user goes back to those pages.
This commit also updates the value on query params and that value
take priority over the cached valued.

Partially addresses cockroachdb#68199

Release note: None
@maryliag
ui: save sort settings and view type on cache for Database Details page
c80933a 
Previously, sort setting and the View type on Databases Details page were not
being stored. With this commits we save the info about sort settings and the
view type so the value is the same when the user goes back to those pages.
This commit also updates the value on query params and that value
take priority over the cached valued.

Partially addresses cockroachdb#68199

Release note: None
@maryliag
ui: select grants tab on table details page
6900c42 
Previosuly, when the grants view was selected on the Database
Details page, it was going to the Table Details with the Overview
tab selected.
With this commit, if the view mode selected is Grant, the grant
tab is selected on the Table Details page.

Fixes cockroachdb#68829

Release note: None
@maryliag maryliag requested a review from a team December 17, 2021 18:58
@blathers-crl
Copy link

blathers-crl bot commented Dec 17, 2021 •
edited by maryliag
Loading

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@Azhng
Copy link
Contributor

Azhng commented Dec 20, 2021

Hmm how do you feel about splitting #73932 to its own backport PR? It seems like it's a little bit unrelated to the database caching?

@maryliag
Copy link
Contributor Author

I guess caching as the name of PR is not the right word, I wanted to group all PRs related to keeping the state of all things selected on Database page, that can be correctly shown if you move back to it, which is also the case for the PR you mentioned. I'll rename this backport

@maryliag maryliag changed the title release-21.2: ui: caching info on database page release-21.2: ui: keep state of selections on database page Dec 20, 2021
Azhng
Azhng approved these changes Dec 21, 2021
View reviewed changes
Copy link
Contributor

@Azhng Azhng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@maryliag maryliag merged commit 8440e09 into cockroachdb:release-21.2 Dec 21, 2021
@maryliag maryliag deleted the backport21.2-73795-73879-73932 branch January 10, 2022 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Azhng Azhng Azhng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maryliag @cockroach-teamcity @Azhng