kvserver: remove data race in onSpanConfigUpdate #75021
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
@irfansharif did some prep work for when your day begins. Mind taking this over from me? It will close a lot of issues, I think :-) |
tbg
commented
Jan 18, 2022
pkg/kv/kvserver/store.go
Outdated
| // mutex for longer than necessary. | ||
| var repls []*Replica | ||
| { | ||
| s.mu.Lock() |
We weren't holding `Store.mu`. This fixes boatloads of nightly issues that I am not going to list here, but which should be linked against this PR when it merges. Release note: None
tbg
force-pushed
the
zonecfg-data-race
branch
from
6098cf6
to
86399fa
Compare
|
bors r=aliher1911 |
|
Build failed: |
|
We're going with #74926 instead, with also fixes the bug but avoids introducing a new data race 🙈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't holding
Store.mu.Fixes: XXX [repeated 100 times]
Release note: None