kvserver: deflake TestBackpressureNotAppliedWhenReducingRangeSize #75598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test relies on a second node's span config rangefeed to have caught up sufficiently with the global state such that a snapshot, when applied, would construct a replica with the config this test attempts to declare over the originating replica. Though very unlikely to occur (repro-ed only once in hours GCE worker runs), it's possible. This patch is a speculative fix for a failure observed only with manual stressing on a SHA that included cockroachdb#75233. (Also make some prominent span config logging a bit more consistent with one another.) Release note: None
|
This change is |
ajwerner
approved these changes
Jan 27, 2022
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @arulajmani)
|
Thanks. bors r+ |
|
Build succeeded: |
irfansharif
deleted the
220126.deflake-TestBackpressureNotAppliedWhenReducingRangeSize
branch
irfansharif
added a commit
to irfansharif/cockroach
that referenced
this pull request
Jan 27, 2022
...TestBackpressureNotAppliedWhenReducingRangeSize. Fixes cockroachdb#75609, a regression we introduced in cockroachdb#75598. When waiting for a span config to materialize on a given node, we were accidentally tripping up on it not being found on the original. Not sure we this slipped CI. Release note: None
irfansharif
added a commit
to irfansharif/cockroach
that referenced
this pull request
Jan 27, 2022
...TestBackpressureNotAppliedWhenReducingRangeSize. Fixes cockroachdb#75609, a regression we introduced in cockroachdb#75598. When waiting for a span config to materialize on a given node, we were accidentally tripping up on it not being found on the original. Not sure we this slipped CI. Release note: None
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test relies on a second node's span config rangefeed to have caught
up sufficiently with the global state such that a snapshot, when
applied, would construct a replica with the config this test attempts to
declare over the originating replica. Though very unlikely to occur
(repro-ed only once in hours GCE worker runs), it's possible. This patch
is a speculative fix for a failure observed only with manual stressing
on a SHA that included #75233.
(Also make some prominent span config logging a bit more consistent with
one another.)
Release note: None