Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ccl/sqlproxyccl: add connection migration-related metrics #77700

Merged
merged 2 commits into from
Mar 14, 2022
Merged

ccl/sqlproxyccl: add connection migration-related metrics #77700

merged 2 commits into from
Mar 14, 2022

Commits on Mar 14, 2022

  1. ccl/sqlproxyccl: add metric that measures connection migration latency 

    Previously, we added support for connection migration in cockroachdb#76805. This commit
adds a new `proxy.conn_migration.attempted.latency` metric that tracks latency
for attempted connection migrations. Having this metric would be beneficial
as we can now know how long users were blocked during connection migrations.

Release justification: Low-risk metric-only change within sqlproxy.

Release note: None
    @jaylim-crl
    jaylim-crl committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    93d685b View commit details
    Browse the repository at this point in the history

  2. ccl/sqlproxyccl: add metric that records the transfer response messag… 

    …e size

Informs cockroachdb#76000, and follow up to cockroachdb#76805.

This commit adds a new proxy.conn_migration.transfer_response.message_size
metric that will track the distribution of the transfer response message size.
This will be used to tune a value for the SQL cluster setting:
sql.session_transfer.max_session_size.

Release justification: Low-risk metric-only change within sqlproxy.

Release note: None
    @jaylim-crl
    jaylim-crl committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    454b896 View commit details
    Browse the repository at this point in the history