raoachtest/versionupgrade: re-enable schema change step again #79921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
postamar
approved these changes
Apr 13, 2022
|
bors r+ |
|
Build failed (retrying...): |
|
bors r- |
|
Canceled. |
Fixes: cockroachdb#58489 Previously, the schema change step inside the version upgrade test was disabled because of failures. This allowed the test to become reliable, but we lost coverage of randomized schema changes in this scenario. To address this, this patch will re-enable the randomized schema changer workload during version upgrade, since we have fixed this workload on its own. Release note: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #58489
Previously, the schema change step inside the version upgrade
test was disabled because of failures. This allowed the test
to become reliable, but we lost coverage of randomized schema
changes in this scenario. To address this, this patch
will re-enable the randomized schema changer workload during
version upgrade, since we have fixed this workload on its
own.
Release note: None