Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raoachtest/versionupgrade: re-enable schema change step again #79921

Closed
wants to merge 1 commit into from
Closed

raoachtest/versionupgrade: re-enable schema change step again #79921

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions pkg/cmd/roachtest/tests/versionupgrade.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,9 +116,6 @@ func runVersionUpgrade(ctx context.Context, t test.Test, c cluster.Cluster) {

testFeaturesStep := versionUpgradeTestFeatures.step(c.All())
schemaChangeStep := runSchemaChangeWorkloadStep(c.All().RandNode()[0], 10 /* maxOps */, 2 /* concurrency */)
// TODO(irfansharif): All schema change instances were commented out while
// of #58489 is being addressed.
_ = schemaChangeStep
backupStep := func(ctx context.Context, t test.Test, u *versionUpgradeTest) {
// Verify that backups can be created in various configurations. This is
// important to test because changes in system tables might cause backups to
Expand Down Expand Up @@ -168,26 +165,26 @@ func runVersionUpgrade(ctx context.Context, t test.Test, c cluster.Cluster) {
// as they ought to.
binaryUpgradeStep(c.All(), predecessorVersion),
testFeaturesStep,
// schemaChangeStep,
schemaChangeStep,
backupStep,
// Roll nodes forward, this time allowing them to upgrade, and waiting
// for it to happen.
binaryUpgradeStep(c.All(), ""),
allowAutoUpgradeStep(1),
testFeaturesStep,
// schemaChangeStep,
schemaChangeStep,
backupStep,
waitForUpgradeStep(c.All()),
testFeaturesStep,
// schemaChangeStep,
schemaChangeStep,
backupStep,
// Turn tracing on globally to give it a fighting chance at exposing any
// crash-inducing incompatibilities or horrendous memory leaks. (It won't
// catch most memory leaks since this test doesn't run for too long or does
// too much work). Then, run the previous tests again.
enableTracingGloballyStep,
testFeaturesStep,
// schemaChangeStep,
schemaChangeStep,
backupStep,
)

Expand Down