release-22.2: workload/mixed-version/schemachanger: re-enable mixed version workload #88536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
|
This change is |
|
There's something weird in these build failures |
fqazi
force-pushed
the
backport22.2-87142-88475
branch
2 times, most recently
from
d546817
to
7975247
Compare
ajwerner
approved these changes
Oct 10, 2022
complete! 1 of 0 LGTMs obtained
…ployed Previously, the schemachanger mixed version workload did not deploy the libGEOS libraries causing operations to fail. To address, this patch will update the frontend to upload these binaries. Release justification: no real risk improves test coverage Release note: None
… state Previously, the schema changer workload in a mixed version state attempted to use trigram indexes against 22.1, which is unsupported. This patch adds code to detect a mixed version state and expects the appropriate error when this occurs. Release justification: no risk improves test coverage Release note: None
Previously, if we ran in a mixed version state with the schema changer workload we could run into an optimizer bug (cockroachdb#80820). To address this, this patch in a mixed version workload disables the insert portion of the workload. Release justification: improves test coverage by enabling the mixed version test Release note: None
Fixes: cockroachdb#87768 Previously, we were generating statements with invisible indexes in mixed version environments, which could lead to statements generated not supported on older versions. To address this, this patch will prevent the generation of create table/ create index statements with invisible indexes. Release note: None
fqazi
force-pushed
the
backport22.2-87142-88475
branch
from
7975247
to
d18da79
Compare
|
@ajwerner TFTR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-enables the mixed version workload for 22.2
Backport:
Please see individual PRs for details.
Release note: None
Release justification: low-risk changes to re-enable the mixed version testing workload
/cc @cockroachdb/release