Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade grpc to v.1.49.0 #88562

Merged
merged 2 commits into from
Sep 23, 2022
Merged

upgrade grpc to v.1.49.0 #88562

merged 2 commits into from
Sep 23, 2022

Conversation

pav-kv
Copy link
Collaborator

@pav-kv pav-kv commented Sep 23, 2022 •
edited
Loading

Fixes #81881
Touches #72083

Release note: upgraded grpc to v1.49.0 to fix a few panics that the old version caused

@pav-kv pav-kv requested a review from erikgrinaker September 23, 2022 13:52
@pav-kv pav-kv requested a review from a team as a code owner September 23, 2022 13:52
@cockroach-teamcity
Copy link
Member

This change is Reviewable

erikgrinaker
erikgrinaker approved these changes Sep 23, 2022
View reviewed changes
Copy link
Contributor

@erikgrinaker erikgrinaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pav-kv
Copy link
Collaborator Author

pav-kv commented Sep 23, 2022

Failing to build some cloud storage files, same error locally.

@erikgrinaker
Copy link
Contributor

erikgrinaker commented Sep 23, 2022 •
edited
Loading

Failing to build some cloud storage files, same error locally.

Did you do go get or go get -u here when upgrading? The former won't upgrade other deps unless necessary.

@pav-kv
Copy link
Collaborator Author

pav-kv commented Sep 23, 2022

I did -u, and all per instruction here.

Locally, I can build with ./dev build short, but make buildshort fails with this error.

@erikgrinaker
Copy link
Contributor

erikgrinaker commented Sep 23, 2022 •
edited
Loading

Well, we have two options: either try without -u and hope it won't pull in the breaking dep, or go ask the DR team to upgrade their code to the new version first (or do it for them if it's trivial).

@pav-kv pav-kv force-pushed the upgrade_grpc_to_1_49 branch from 2ef4ef1 to b4b447c Compare September 23, 2022 14:55
@pav-kv
Copy link
Collaborator Author

pav-kv commented Sep 23, 2022 •
edited
Loading

Trying without -u. Locally the build succeeded.

@pav-kv
Copy link
Collaborator Author

pav-kv commented Sep 23, 2022

bors r=erikgrinaker

@pav-kv
Copy link
Collaborator Author

pav-kv commented Sep 23, 2022

bors retry

@craig
Copy link
Contributor

craig bot commented Sep 23, 2022

Already running a review

@pav-kv
*: upgrade grpc to v1.48.0
ee6fb9f 
Release note: upgraded grpc to v1.48.0
@pav-kv
*: upgrade grpc to v1.49.0
883883f 
Release note: upgraded grpc to v1.49.0
@pav-kv pav-kv force-pushed the upgrade_grpc_to_1_49 branch from b4b447c to 883883f Compare September 23, 2022 17:27
@craig
Copy link
Contributor

craig bot commented Sep 23, 2022

Canceled.

@pav-kv
Copy link
Collaborator Author

pav-kv commented Sep 23, 2022

Someone updated another dependency. Rebased.

@pav-kv
Copy link
Collaborator Author

pav-kv commented Sep 23, 2022

bors r=erikgrinaker

@craig
Copy link
Contributor

craig bot commented Sep 23, 2022

Build succeeded:

@craig craig bot merged commit 2c18ed3 into cockroachdb:master Sep 23, 2022
@pav-kv pav-kv deleted the upgrade_grpc_to_1_49 branch September 23, 2022 18:39
@pav-kv pav-kv mentioned this pull request Sep 23, 2022
Merged
@knz knz mentioned this pull request Nov 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikgrinaker erikgrinaker erikgrinaker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gossip: TestGossipOrphanedStallDetection failed
3 participants
@pav-kv @cockroach-teamcity @erikgrinaker