-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-22.2: upgrade grpc to v.1.49.0 #88630
Conversation
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
f3a218c
to
e0fd13c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we'll need to update some Bazel files as well:
------- Stderr: -------
HEAD detached at e0fd13c482
You are in a sparse checkout with 100% of tracked files present.
Changes not staged for commit:
(use "git add <file>..." to update what will be committed)
(use "git restore <file>..." to discard changes in working directory)
modified: pkg/BUILD.bazel
no changes added to commit (use "git add" and/or "git commit -a")
diff --git a/pkg/BUILD.bazel b/pkg/BUILD.bazel
index 54bf794ead..8be6578e38 100644
--- a/pkg/BUILD.bazel
+++ b/pkg/BUILD.bazel
@@ -1864,7 +1864,6 @@ GO_TARGETS = [
"//pkg/util/admission:admission",
"//pkg/util/admission:admission_test",
"//pkg/util/arith:arith",
- "//pkg/util/atomic:atomic",
"//pkg/util/binfetcher:binfetcher",
"//pkg/util/binfetcher:binfetcher_test",
"//pkg/util/bitarray:bitarray",
@@ -2872,7 +2871,6 @@ GET_X_DATA_TARGETS = [
"//pkg/util/admission:get_x_data",
"//pkg/util/admission/admissionpb:get_x_data",
"//pkg/util/arith:get_x_data",
- "//pkg/util/atomic:get_x_data",
"//pkg/util/binfetcher:get_x_data",
"//pkg/util/bitarray:get_x_data",
"//pkg/util/bufalloc:get_x_data",
====================================================
Some automatically generated code is not up to date.
Run `./dev generate bazel` to automatically regenerate these.
Not sure if these are directly related to this PR, or some cruft from before, but we'll need them for green CI.
Release justification: fixes crashes caused by grpc Release note (bug fix): upgraded grpc to v1.49.0 which fixed a few panics on nil pointers
e0fd13c
to
e9515af
Compare
Done. I think that was a side effect from my local untracked files. |
Backport 1/2 commits from #88562.
/cc @cockroachdb/release
Fixes #81881
Touches #72083
Release justification: fixes crashes caused by grpc
Release note (bug fix): upgraded grpc to v1.49.0 which fixed a few panics on
nil pointers