Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.2: upgrade grpc to v.1.49.0 #88630

Merged
merged 1 commit into from
Sep 26, 2022

Conversation

pav-kv
Copy link
Collaborator

@pav-kv pav-kv commented Sep 23, 2022

Backport 1/2 commits from #88562.

/cc @cockroachdb/release


Fixes #81881
Touches #72083

Release justification: fixes crashes caused by grpc
Release note (bug fix): upgraded grpc to v1.49.0 which fixed a few panics on
nil pointers

@pav-kv pav-kv requested a review from a team as a code owner September 23, 2022 21:57
@blathers-crl
Copy link

blathers-crl bot commented Sep 23, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@erikgrinaker erikgrinaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we'll need to update some Bazel files as well:

------- Stderr: -------
HEAD detached at e0fd13c482
You are in a sparse checkout with 100% of tracked files present.
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
  modified:   pkg/BUILD.bazel
no changes added to commit (use "git add" and/or "git commit -a")
diff --git a/pkg/BUILD.bazel b/pkg/BUILD.bazel
index 54bf794ead..8be6578e38 100644
--- a/pkg/BUILD.bazel
+++ b/pkg/BUILD.bazel
@@ -1864,7 +1864,6 @@ GO_TARGETS = [
     "//pkg/util/admission:admission",
     "//pkg/util/admission:admission_test",
     "//pkg/util/arith:arith",
-    "//pkg/util/atomic:atomic",
     "//pkg/util/binfetcher:binfetcher",
     "//pkg/util/binfetcher:binfetcher_test",
     "//pkg/util/bitarray:bitarray",
@@ -2872,7 +2871,6 @@ GET_X_DATA_TARGETS = [
     "//pkg/util/admission:get_x_data",
     "//pkg/util/admission/admissionpb:get_x_data",
     "//pkg/util/arith:get_x_data",
-    "//pkg/util/atomic:get_x_data",
     "//pkg/util/binfetcher:get_x_data",
     "//pkg/util/bitarray:get_x_data",
     "//pkg/util/bufalloc:get_x_data",
====================================================
Some automatically generated code is not up to date.
Run `./dev generate bazel` to automatically regenerate these.

Not sure if these are directly related to this PR, or some cruft from before, but we'll need them for green CI.

Release justification: fixes crashes caused by grpc
Release note (bug fix): upgraded grpc to v1.49.0 which fixed a few panics on
nil pointers
@pav-kv
Copy link
Collaborator Author

pav-kv commented Sep 26, 2022

Done. I think that was a side effect from my local untracked files.

@pav-kv pav-kv merged commit fe2a382 into cockroachdb:release-22.2 Sep 26, 2022
@pav-kv pav-kv deleted the backport22.2-88562 branch September 26, 2022 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants