kv: deflake raceTransport after pass-by-ref BatchRequest #91031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the broken compilation of `raceTransport`, which was broken by e822649. That commit made its way through CI without triggering a race build with the silent log: `changed many packages; skipping race detector tests` This commit also fixes a few tests that now fail under race due to the `raceTransport` by shallow cloning the BatchRequest before mutation in the `DistSender.sendToReplicas` and `TracingInternalClient.Batch`. Epic: None Release note: None
|
This change is |
arulajmani
approved these changes
Nov 1, 2022
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @nvanbenschoten)
|
TFTR! bors r=arulajmani |
|
Build failed: |
|
Bors failed on bors r=arulajmani |
|
Build failed (retrying...): |
|
bors r- Flake on |
|
Canceled. |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the broken compilation of
raceTransport, which was broken by e822649. That commit made its way through CI without triggering a race build with the silent log:This commit also fixes a few tests that now fail under race due to the
raceTransportby shallow cloning the BatchRequest before mutation in theDistSender.sendToReplicasandTracingInternalClient.Batch.Epic: None
Release note: None